From fe4922cbf01fa9161ffa142fc70972098d48186f Mon Sep 17 00:00:00 2001 From: Michael Albinus <michael.albinus@gmx.de> Date: Thu, 3 Jan 2019 18:55:11 +0100 Subject: [PATCH] Mark some filenotify tests unstable on emba * .gitlab-ci.yml (test): Add EMACS_EMBA_CI variable. * test/lisp/filenotify-tests.el (file-notify-test03-events) (file-notify-test05-file-validity) (file-notify-test06-dir-validity) (file-notify-test07-many-events) (file-notify-test09-watched-file-in-watched-dir): Mark them as :unstable on emba. --- .gitlab-ci.yml | 2 ++ test/lisp/filenotify-tests.el | 9 +++++++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index af573affc93..ff51c20726b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -35,6 +35,8 @@ stages: test: stage: test + variables: + EMACS_EMBA_CI: 1 script: - ./autogen.sh autoconf - ./configure --without-makeinfo diff --git a/test/lisp/filenotify-tests.el b/test/lisp/filenotify-tests.el index 02830791542..d4e65af4186 100644 --- a/test/lisp/filenotify-tests.el +++ b/test/lisp/filenotify-tests.el @@ -588,6 +588,7 @@ delivered." (ert-deftest file-notify-test03-events () "Check file creation/change/removal notifications." + :tags (if (getenv "EMACS_EMBA_CI") '(:unstable)) (skip-unless (file-notify--test-local-enabled)) (unwind-protect @@ -945,6 +946,7 @@ delivered." (ert-deftest file-notify-test05-file-validity () "Check `file-notify-valid-p' for files." + :tags (if (getenv "EMACS_EMBA_CI") '(:unstable)) (skip-unless (file-notify--test-local-enabled)) (unwind-protect @@ -1057,6 +1059,7 @@ delivered." (ert-deftest file-notify-test06-dir-validity () "Check `file-notify-valid-p' for directories." + :tags (if (getenv "EMACS_EMBA_CI") '(:unstable)) (skip-unless (file-notify--test-local-enabled)) (unwind-protect @@ -1115,7 +1118,8 @@ delivered." (ert-deftest file-notify-test07-many-events () "Check that events are not dropped." - :tags '(:expensive-test) + :tags (if (getenv "EMACS_EMBA_CI") + '(:expensive-test :unstable) '(:expensive-test)) (skip-unless (file-notify--test-local-enabled)) (should @@ -1274,7 +1278,8 @@ descriptors that were issued when registering the watches. This test caters for the situation in bug#22736 where the callback for the directory received events for the file with the descriptor of the file watch." - :tags '(:expensive-test) + :tags (if (getenv "EMACS_EMBA_CI") + '(:expensive-test :unstable) '(:expensive-test)) (skip-unless (file-notify--test-local-enabled)) ;; A directory to be watched. -- 2.39.5