From fa3c87e1f21cd100ccb257d5dd41047d0c9a732b Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 18 Apr 2011 23:42:12 -0700 Subject: [PATCH] * process.c (Fnetwork_interface_info): Avoid left-shift undefined behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts. --- src/ChangeLog | 3 +++ src/process.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/ChangeLog b/src/ChangeLog index 2b2a9510435..f109718fadb 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,8 @@ 2011-04-19 Paul Eggert + * process.c (Fnetwork_interface_info): Avoid left-shift undefined + behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts. + * xfns.c (Fx_window_property): Simplify a bit, to make a bit faster and to avoid GCC 4.6.0 warning. * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise. diff --git a/src/process.c b/src/process.c index 8fbd8ac92e2..f25d10dbd67 100644 --- a/src/process.c +++ b/src/process.c @@ -3723,9 +3723,9 @@ FLAGS is the current flags of the interface. */) flags -= fp->flag_bit; } } - for (fnum = 0; flags && fnum < 32; fnum++) + for (fnum = 0; flags && fnum < 32; flags >>= 1, fnum++) { - if (flags & (1 << fnum)) + if (flags & 1) { elt = Fcons (make_number (fnum), elt); } -- 2.39.5