From f2ba34f4ede9384f265f7884980e9c4c5c1af306 Mon Sep 17 00:00:00 2001 From: Ken Raeburn Date: Mon, 20 May 2002 08:38:28 +0000 Subject: [PATCH] update LISP_MAKE_RVALUE comment for union, non-gcc case --- src/lisp.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lisp.h b/src/lisp.h index d8bb5bf08af..c179e8d04d2 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -235,7 +235,11 @@ LISP_MAKE_RVALUE (Lisp_Object o) return o; } #else -#define LISP_MAKE_RVALUE(o) (o) /* XXX - keeps arg as rvalue. */ +/* This isn't quite right - it keeps the argument as an lvalue. + Making it const via casting would help avoid code actually + modifying the location in question, but the casting could cover + other type-related bugs. */ +#define LISP_MAKE_RVALUE(o) (o) #endif #endif /* NO_UNION_TYPE */ -- 2.39.5