From f2602864b661c32888029f38921fb19f65bf337e Mon Sep 17 00:00:00 2001 From: Chong Yidong Date: Tue, 7 Oct 2008 19:47:49 +0000 Subject: [PATCH] (command-line): Use display-warning to warn about an init file error. (command-line-1): Remove init file error delay. --- lisp/startup.el | 45 ++++++++++++++++----------------------------- 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/lisp/startup.el b/lisp/startup.el index fa21cca8776..11ab1593463 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -1069,28 +1069,20 @@ opening the first frame (e.g. open a connection to an X server).") (funcall inner) (setq init-file-had-error nil)) (error - (let ((message-log-max nil)) - (with-current-buffer (get-buffer-create "*Messages*") - (insert "\n\n" - (format "An error has occurred while loading `%s':\n\n" - user-init-file) - (format "%s%s%s" - (get (car error) 'error-message) - (if (cdr error) ": " "") - (mapconcat (lambda (s) (prin1-to-string s t)) (cdr error) ", ")) - "\n\n" - "To ensure normal operation, you should investigate and remove the\n" - "cause of the error in your initialization file. Start Emacs with\n" - "the `--debug-init' option to view a complete error backtrace.\n\n")) - (message "Error in init file: %s%s%s" - (get (car error) 'error-message) - (if (cdr error) ": " "") - (mapconcat 'prin1-to-string (cdr error) ", ")) - (let ((pop-up-windows nil)) - (pop-to-buffer "*Messages*")) - (setq init-file-had-error t))))) - - (if (and deactivate-mark transient-mark-mode) + (display-warning + 'initialization + (format "An error occurred while loading `%s':\n\n%s%s%s\n\n\ +To ensure normal operation, you should investigate and remove the +cause of the error in your initialization file. Start Emacs with +the `--debug-init' option to view a complete error backtrace." + user-init-file + (get (car error) 'error-message) + (if (cdr error) ": " "") + (mapconcat (lambda (s) (prin1-to-string s t)) (cdr error) ", ")) + :warning) + (setq init-file-had-error t)))) + + (if (and deactivate-mark transient-mark-mode) (with-current-buffer (window-buffer) (deactivate-mark))) @@ -2051,17 +2043,12 @@ A fancy display is used on graphic displays, normal otherwise." (defun command-line-1 (command-line-args-left) (display-startup-echo-area-message) - - ;; Delay 2 seconds after an init file error message - ;; was displayed, so user can read it. - (when init-file-had-error - (sit-for 2)) - (when (and pure-space-overflow (not noninteractive)) (display-warning 'initialization - "Building Emacs overflowed pure space. (See the node Pure Storage in the Lisp manual for details.)" + "Building Emacs overflowed pure space.\ + (See the node Pure Storage in the Lisp manual for details.)" :warning)) (let ((file-count 0) -- 2.39.5