From f1dae2551c9b30f1f1333416df195b0907c54f4f Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Mon, 14 Dec 2020 15:09:14 +0100 Subject: [PATCH] Prefer setq to set+quote * lisp/cedet/semantic/senator.el (senator-lazy-highlight-update): * lisp/emulation/edt.el (edt-find, edt-restore-key) (edt-remember): * lisp/eshell/em-ls.el (eshell-ls--insert-directory): * lisp/net/tramp-sh.el (tramp-sh-handle-write-region): * lisp/progmodes/hideif.el (hide-ifdef-mode): * test/lisp/url/url-future-tests.el (url-future-tests): Prefer setq to set+quote. --- lisp/cedet/semantic/senator.el | 2 +- lisp/emulation/edt.el | 12 ++++++------ lisp/eshell/em-ls.el | 6 +++--- lisp/net/tramp-sh.el | 2 +- lisp/progmodes/hideif.el | 2 +- test/lisp/url/url-future-tests.el | 8 ++++---- 6 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lisp/cedet/semantic/senator.el b/lisp/cedet/semantic/senator.el index 49c1933508f..d21350749ba 100644 --- a/lisp/cedet/semantic/senator.el +++ b/lisp/cedet/semantic/senator.el @@ -810,7 +810,7 @@ if available." (defun senator-lazy-highlight-update () "Force lazy highlight update." (lazy-highlight-cleanup t) - (set 'isearch-lazy-highlight-last-string nil) + (setq isearch-lazy-highlight-last-string nil) (setq isearch-adjusted t) (isearch-update)) diff --git a/lisp/emulation/edt.el b/lisp/emulation/edt.el index f61de9208d1..7601731a85a 100644 --- a/lisp/emulation/edt.el +++ b/lisp/emulation/edt.el @@ -691,7 +691,7 @@ Optional argument FIND is t if this function is called from `edt-find'." (defun edt-find () "Find first occurrence of string in current direction and save it." (interactive) - (set 'edt-find-last-text (read-string "Search: ")) + (setq edt-find-last-text (read-string "Search: ")) (if (equal edt-direction-string edt-forward-string) (edt-find-forward t) (edt-find-backward t))) @@ -1321,8 +1321,8 @@ Definition is stored in `edt-last-replaced-key-definition'." (if edt-last-replaced-key-definition (progn (let (edt-key-definition) - (set 'edt-key-definition - (read-key-sequence "Press the key to be restored: ")) + (setq edt-key-definition + (read-key-sequence "Press the key to be restored: ")) (if (string-equal "\C-m" edt-key-definition) (message "Key not restored") (progn @@ -1639,12 +1639,12 @@ Argument NUM is the number of times to duplicate the line." (progn (end-kbd-macro nil) (let (edt-key-definition) - (set 'edt-key-definition - (read-key-sequence "Enter key for binding: ")) + (setq edt-key-definition + (read-key-sequence "Enter key for binding: ")) (if (string-equal "\C-m" edt-key-definition) (message "Key sequence not remembered") (progn - (set 'edt-learn-macro-count (+ edt-learn-macro-count 1)) + (setq edt-learn-macro-count (+ edt-learn-macro-count 1)) (setq edt-last-replaced-key-definition (lookup-key (current-global-map) edt-key-definition)) diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 6b306f77874..44a0df6a3ed 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el @@ -274,9 +274,9 @@ instead." (font-lock-mode -1) (setq font-lock-defaults nil) (if (boundp 'font-lock-buffers) - (set 'font-lock-buffers - (delq (current-buffer) - (symbol-value 'font-lock-buffers))))) + (setq font-lock-buffers + (delq (current-buffer) + (symbol-value 'font-lock-buffers))))) (require 'em-glob) (let* ((insert-func 'insert) (error-func 'insert) diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el index 98537a100f3..34be4fcba93 100644 --- a/lisp/net/tramp-sh.el +++ b/lisp/net/tramp-sh.el @@ -3562,7 +3562,7 @@ implementation will be used." ;; Make `last-coding-system-used' have the right value. (when coding-system-used - (set 'last-coding-system-used coding-system-used)))) + (setq last-coding-system-used coding-system-used)))) (tramp-flush-file-properties v localname) diff --git a/lisp/progmodes/hideif.el b/lisp/progmodes/hideif.el index 7cbc9708fce..9c8343fca00 100644 --- a/lisp/progmodes/hideif.el +++ b/lisp/progmodes/hideif.el @@ -304,7 +304,7 @@ Several variables affect how the hiding is done: ;; (C-c @ C) every time before hiding current buffer. ;; (setq-local hide-ifdef-env ;; (default-value 'hide-ifdef-env)) - (set 'hide-ifdef-env (default-value 'hide-ifdef-env)) + (setq hide-ifdef-env (default-value 'hide-ifdef-env)) ;; Some C/C++ headers might have other ways to prevent reinclusion and ;; thus would like `hide-ifdef-expand-reinclusion-protection' to be nil. (setq-local hide-ifdef-expand-reinclusion-protection diff --git a/test/lisp/url/url-future-tests.el b/test/lisp/url/url-future-tests.el index a07730a2be6..43668036b69 100644 --- a/test/lisp/url/url-future-tests.el +++ b/test/lisp/url/url-future-tests.el @@ -31,13 +31,13 @@ (let* (url-future-tests--saver (text "running future") (good (make-url-future :value (lambda () (format text)) - :callback (lambda (f) (set 'url-future-tests--saver f)))) + :callback (lambda (f) (setq url-future-tests--saver f)))) (bad (make-url-future :value (lambda () (/ 1 0)) - :errorback (lambda (&rest d) (set 'url-future-tests--saver d)))) + :errorback (lambda (&rest d) (setq url-future-tests--saver d)))) (tocancel (make-url-future :value (lambda () (/ 1 0)) - :callback (lambda (f) (set 'url-future-tests--saver f)) + :callback (lambda (f) (setq url-future-tests--saver f)) :errorback (lambda (&rest d) - (set 'url-future-tests--saver d))))) + (setq url-future-tests--saver d))))) (should (equal good (url-future-call good))) (should (equal good url-future-tests--saver)) (should (equal text (url-future-value good))) -- 2.39.2