From f14869cd70e61b1908ec88a5e3d4bf21c7d538a0 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sat, 2 Jan 2021 22:27:53 +0000 Subject: [PATCH] Fix crash when using menus and tramp on NS ; Fixes bug#24472, bug#37557 and bug#37922. * src/nsterm.m (ns_select): Don't drain outerpool in this function. --- src/nsterm.m | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/src/nsterm.m b/src/nsterm.m index a4ee1476933..27310639508 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -4721,8 +4721,22 @@ ns_select (int nfds, fd_set *readfds, fd_set *writefds, thread_select(pselect, 0, NULL, NULL, NULL, &t, sigmask); } - [outerpool release]; - outerpool = [[NSAutoreleasePool alloc] init]; + /* FIXME: This draining of outerpool causes a crash when a buffer + running over tramp is displayed and the user tries to use the + menus. I believe some other autorelease pool's lifetime + straddles this call causing a violation of autorelease pool + nesting. There's no good reason to keep these here since the + pool will be drained some other time anyway, but removing them + leaves the menus sometimes not opening until the user moves their + mouse pointer, but that's better than a crash. + + There must be something about running external processes like + tramp that interferes with the modal menu code. + + See bugs 24472, 37557, 37922. */ + + // [outerpool release]; + // outerpool = [[NSAutoreleasePool alloc] init]; send_appdefined = YES; -- 2.39.5