From f028a893a552b0c38c35f949addb6a891e8586cc Mon Sep 17 00:00:00 2001 From: Masahiro Nakamura Date: Tue, 15 Sep 2020 15:35:32 +0900 Subject: [PATCH] ; Minor fix for nsxwidget patch * lisp/xwdget.el (xwidget-webkit-download-dir) (xwidget-webkit-save-as-file): Set version to 28.1 because the patch was introduced in Emacs 28.0.50. * src/nsxwidget.m: Fix typo. --- lisp/xwidget.el | 4 ++-- src/nsxwidget.m | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index 074320855c5..e5c1b47f3b1 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -318,7 +318,7 @@ If non-nil, plugins are enabled. Otherwise, disabled.")) (defcustom xwidget-webkit-download-dir "~/Downloads/" "Directory where download file saved." - :version "27.1" + :version "28.1" :type 'file) (defun xwidget-webkit-save-as-file (url mime-type file-name) @@ -348,7 +348,7 @@ If non-nil, use a new xwidget webkit session after bookmark jump. Otherwise, it will use `xwidget-webkit-last-session'. When you set this variable to nil, consider further customization with `xwidget-webkit-last-session-buffer'." - :version "27.1" + :version "28.1" :type 'boolean) (defun xwidget-webkit-bookmark-make-record () diff --git a/src/nsxwidget.m b/src/nsxwidget.m index e81ca7fc0cb..2910d97225a 100644 --- a/src/nsxwidget.m +++ b/src/nsxwidget.m @@ -33,14 +33,14 @@ along with GNU Emacs. If not, see . */ /* Thoughts on NS Cocoa xwidget and webkit2: Webkit2 process architecture seems to be very hostile for offscreen - rendering techniques, which is used by GTK xwiget implementation; + rendering techniques, which is used by GTK xwidget implementation; Specifically NSView level view sharing / copying is not working. *** So only one view can be associcated with a model. *** With this decision, implementation is plain and can expect best out of webkit2's rationale. But process and session structures will - diverge from GTK xwiget. Though, cosmetically similar usages can + diverge from GTK xwidget. Though, cosmetically similar usages can be presented and will be preferred, if agreeable. For other widget types, OSR seems possible, but will not care for a -- 2.39.5