From ef6432e7396e32b2bb264392f33e2fa5b51f1a85 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 21 Jan 2025 22:19:08 -0800 Subject: [PATCH] Check for snprintf truncation in pgtkterm * src/pgtkterm.c (pgtk_enumerate_devices): Abort if snprintf truncated. (cherry picked from commit db9ea9b77a0d03342bfe2a976b3943de5e5a4518) --- src/pgtkterm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/pgtkterm.c b/src/pgtkterm.c index 413cbd86c0d..30679353c1b 100644 --- a/src/pgtkterm.c +++ b/src/pgtkterm.c @@ -183,9 +183,10 @@ pgtk_enumerate_devices (struct pgtk_display_info *dpyinfo, rec->seat = g_object_ref (seat); rec->device = GDK_DEVICE (t1->data); - snprintf (printbuf, 1026, "%u:%s", - gdk_device_get_source (rec->device), - gdk_device_get_name (rec->device)); + int len = snprintf (printbuf, sizeof printbuf, "%u:%s", + gdk_device_get_source (rec->device), + gdk_device_get_name (rec->device)); + eassert (len < sizeof printbuf); rec->name = build_string (printbuf); rec->next = dpyinfo->devices; -- 2.39.5