From ecf88e6a1c903796ce397be38990e10813fd506d Mon Sep 17 00:00:00 2001 From: Eval EXEC Date: Fri, 5 Jul 2024 18:53:36 +0800 Subject: [PATCH] Improve 'tab-line-tabs-fixed-window-buffers' sorting performance * lsp/tab-line.el (tab-line-tabs-fixed-window-buffers): Enhance 'tab-line-tabs-fixed-window-buffers' performance by optimizing buffer sorting mechanism. Replace inefficient 'seq-position' calls with a hash table to cache buffer positions, significantly improving speed when handling large buffer lists (bug#71958). Copyright-paperwork-exempt: yes (cherry picked from commit fffab032b05d5dcb72d6729321739ca814c54a28) --- lisp/tab-line.el | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/tab-line.el b/lisp/tab-line.el index 1d14fda9825..462a0a27692 100644 --- a/lisp/tab-line.el +++ b/lisp/tab-line.el @@ -555,10 +555,15 @@ This means that switching to a buffer previously shown in the same window will keep the same order of tabs that was before switching. And newly displayed buffers are added to the end of the tab line." (let* ((old-buffers (window-parameter nil 'tab-line-buffers)) + (buffer-positions (let ((index-table (make-hash-table :test 'eq))) + (seq-do-indexed + (lambda (buf idx) (puthash buf idx index-table)) + old-buffers) + index-table)) (new-buffers (sort (tab-line-tabs-window-buffers) :key (lambda (buffer) - (or (seq-position old-buffers buffer) - most-positive-fixnum))))) + (gethash buffer buffer-positions + most-positive-fixnum))))) (set-window-parameter nil 'tab-line-buffers new-buffers) new-buffers)) -- 2.39.2