From eb49b13608d6cf06af52c7d9fe88928a48f48cee Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 18 Jun 2011 17:06:17 -0700 Subject: [PATCH] * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). This didn't break anything, but it didn't help either. It's confusing to put a bogus integer in a place where the actual value does not matter. --- src/ChangeLog | 7 +++++++ src/lisp.h | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index aa0a0a39bb8..1b4edb91d1a 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,10 @@ +2011-06-19 Paul Eggert + + * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr). + This didn't break anything, but it didn't help either. + It's confusing to put a bogus integer in a place where the actual + value does not matter. + 2011-06-18 Paul Eggert * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT. diff --git a/src/lisp.h b/src/lisp.h index 2dcf73b7506..e065bad10d0 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -1890,7 +1890,7 @@ typedef struct { #define DEFUN(lname, fnname, sname, minargs, maxargs, intspec, doc) \ Lisp_Object fnname DEFUN_ARGS_ ## maxargs ; \ static DECL_ALIGN (struct Lisp_Subr, sname) = \ - { PVEC_SUBR | (sizeof (struct Lisp_Subr) / sizeof (EMACS_INT)), \ + { PVEC_SUBR, \ { .a ## maxargs = fnname }, \ minargs, maxargs, lname, intspec, 0}; \ Lisp_Object fnname -- 2.39.2