From e5e335424c3455b06d8942f7cda2d17f04612713 Mon Sep 17 00:00:00 2001 From: Radon Rosborough Date: Mon, 3 Apr 2017 10:40:46 -0700 Subject: [PATCH] Add comment explaining keyword-argument patch --- lisp/use-package/use-package.el | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/lisp/use-package/use-package.el b/lisp/use-package/use-package.el index 440ffa02065..02a358c7145 100644 --- a/lisp/use-package/use-package.el +++ b/lisp/use-package/use-package.el @@ -969,6 +969,25 @@ If RECURSED is non-nil, recurse into sublists." (prog1 (let ((ret (use-package-normalize-pairs key-pred val-pred name label x t))) + ;; Currently, the handling of keyword + ;; arguments by `use-package' and `bind-key' + ;; is non-uniform and undocumented. As a + ;; result, `use-package-normalize-pairs' (as + ;; it is currently implemented) does not + ;; correctly handle the keyword-argument + ;; syntax of `bind-keys'. A permanent solution + ;; to this problem will require a careful + ;; consideration of the desired + ;; keyword-argument interface for + ;; `use-package' and `bind-key'. However, in + ;; the meantime, we have a quick patch to fix + ;; a serious bug in the handling of keyword + ;; arguments. Namely, the code below would + ;; normally unwrap lists that were passed as + ;; keyword arguments (for example, the + ;; `:filter' argument in `:bind') without + ;; the (not (keywordp last-item)) clause. See + ;; #447 for further discussion. (if (and (listp ret) (not (keywordp last-item))) (car ret) ret)) -- 2.39.2