From df9417ac57ac61e928030d036c603be5268a00ea Mon Sep 17 00:00:00 2001
From: =?utf8?q?Gerd=20M=C3=B6llmann?= <gerd@gnu.org>
Date: Thu, 20 Oct 2022 10:21:34 +0200
Subject: [PATCH] Remove Lisp_Symbol::external

---
 src/alloc.c   | 1 -
 src/lisp.h    | 9 ---------
 src/pdumper.c | 1 -
 src/pkg.c     | 1 -
 4 files changed, 12 deletions(-)

diff --git a/src/alloc.c b/src/alloc.c
index 3b1d7cf0b2e..7f439aedd8d 100644
--- a/src/alloc.c
+++ b/src/alloc.c
@@ -3675,7 +3675,6 @@ init_symbol (Lisp_Object val, Lisp_Object name)
   p->u.s.trapped_write = SYMBOL_UNTRAPPED_WRITE;
   p->u.s.declared_special = false;
   p->u.s.pinned = false;
-  p->u.s.external = false;
 }
 
 DEFUN ("make-symbol", Fmake_symbol, Smake_symbol, 1, 1, 0,
diff --git a/src/lisp.h b/src/lisp.h
index 8e33a3b5ba5..5417881a0ad 100644
--- a/src/lisp.h
+++ b/src/lisp.h
@@ -850,9 +850,6 @@ struct Lisp_Symbol
       /* True if pointed to from purespace and hence can't be GC'd.  */
       bool_bf pinned : 1;
 
-      /* True if external symbol in its home package.  */
-      bool_bf external : 1;
-
       /* The symbol's name, as a Lisp string.  */
       Lisp_Object name;
 
@@ -2416,12 +2413,6 @@ SYMBOL_PACKAGE (Lisp_Object sym)
   return XSYMBOL (sym)->u.s.package;
 }
 
-INLINE bool
-SYMBOL_EXTERNAL_P (Lisp_Object sym)
-{
-  return XSYMBOL (sym)->u.s.external;
-}
-
 INLINE bool
 SYMBOL_KEYWORD_P (Lisp_Object sym)
 {
diff --git a/src/pdumper.c b/src/pdumper.c
index 1caa09d2b0e..59e46aab282 100644
--- a/src/pdumper.c
+++ b/src/pdumper.c
@@ -2449,7 +2449,6 @@ dump_symbol (struct dump_context *ctx,
   DUMP_FIELD_COPY (&out, symbol, u.s.trapped_write);
   DUMP_FIELD_COPY (&out, symbol, u.s.declared_special);
   DUMP_FIELD_COPY (&out, symbol, u.s.pinned);
-  DUMP_FIELD_COPY (&out, symbol, u.s.external);
   dump_field_lv (ctx, &out, symbol, &symbol->u.s.name, WEIGHT_STRONG);
   switch (symbol->u.s.redirect)
     {
diff --git a/src/pkg.c b/src/pkg.c
index 3d1a6dcf537..ace28ea1ae6 100644
--- a/src/pkg.c
+++ b/src/pkg.c
@@ -266,7 +266,6 @@ pkg_add_symbol (Lisp_Object symbol, Lisp_Object status, Lisp_Object package)
   eassert (SYMBOLP (symbol));
   eassert (SYMBOLP (status));
   eassert (PACKAGEP (package));
-  XSYMBOL (symbol)->u.s.external = EQ (package, Vkeyword_package);
   Fputhash (symbol, status, PACKAGE_SYMBOLS (package));
   return symbol;
 }
-- 
2.39.2