From da1b4f552064c85f6da82775979a00670c9137a8 Mon Sep 17 00:00:00 2001 From: Jim Porter Date: Sun, 20 Jul 2025 12:49:40 -0700 Subject: [PATCH] Fix EWW

properties when it's on the same line as
 other text

* lisp/net/eww.el (eww-tag-textarea): Set 'start' after ensuring
preceding newline.

* test/lisp/net/eww-tests.el (eww-test/tag/textarea/starts-on-new-line):
New test.

(cherry picked from commit 49376118a1cec24d185fdf1ed2d5bb5bfc116699)
---
 lisp/net/eww.el            |  6 +++---
 test/lisp/net/eww-tests.el | 23 +++++++++++++++++++++++
 2 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 5c1c803e6c9..accd7eec5c3 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1868,12 +1868,12 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.")
                'display (make-string (length value) ?*)))))))))
 
 (defun eww-tag-textarea (dom)
-  (let ((start (point))
-        (value (or (dom-text dom) ""))
+  (let ((value (or (dom-text dom) ""))
 	(lines (string-to-number (or (dom-attr dom 'rows) "10")))
 	(width (string-to-number (or (dom-attr dom 'cols) "10")))
-	end form)
+	start end form)
     (shr-ensure-newline)
+    (setq start (point))
     (insert value)
     (shr-ensure-newline)
     (when (< (count-lines start (point)) lines)
diff --git a/test/lisp/net/eww-tests.el b/test/lisp/net/eww-tests.el
index 82682eae88c..fc1d9bf9184 100644
--- a/test/lisp/net/eww-tests.el
+++ b/test/lisp/net/eww-tests.el
@@ -83,6 +83,29 @@ temporary EWW buffer for our tests."
                        (`(base ((href . ,url)) ,_) url))
                      "http://example.invalid/")))))
 
+(ert-deftest eww-test/tag/textarea/starts-on-new-line ()
+  "Test that inserting a newline before a <textarea> works correctly."
+  (skip-unless (libxml-available-p))
+  (eww-test--with-mock-retrieve
+    (let ((shr-fill-text nil)
+          (eww-test--response-function
+           (lambda (_url)
+             (concat "Content-Type: text/html\n\n"
+                     "<html><body>"
+                     "field: <textarea>text

" + "")))) + (eww "example.invalid") + ;; Make sure the text before the