From d791cc3bc2781435f7b54fb9b45c690c7e4e0ee6 Mon Sep 17 00:00:00 2001 From: Bastien Guerry Date: Mon, 13 Jan 2014 11:55:22 +0100 Subject: [PATCH] Partially fix Bug#16403. * rect.el (rectangle-mark-mode): When the region is not active, display a message saying that the mark as been set and that rectangle mode is in use. (rectangle--highlight-for-redisplay): Only put an overlay with a visible vertical bar when (display-graphic-p) is non-nil. This partially fixes Bug#16403. --- lisp/ChangeLog | 9 +++++++++ lisp/rect.el | 9 +++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 93436bf3cb3..c0b693340f5 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,12 @@ +2014-01-13 Bastien Guerry + + * rect.el (rectangle-mark-mode): When the region is not active, + display a message saying that the mark as been set and that + rectangle mode is in use. + (rectangle--highlight-for-redisplay): Only put an overlay with a + visible vertical bar when (display-graphic-p) is non-nil. + This partially fixes Bug#16403. + 2014-01-13 Juri Linkov * info.el (Info-find-file): Go to DIR before displaying the error diff --git a/lisp/rect.el b/lisp/rect.el index f1f0b8dd9de..e798b07b556 100644 --- a/lisp/rect.el +++ b/lisp/rect.el @@ -444,7 +444,8 @@ Activates the region if needed. Only lasts until the region is deactivated." (lambda () (rectangle-mark-mode -1))) (unless (region-active-p) (push-mark) - (activate-mark)))) + (activate-mark) + (message "Mark set (rectangle mode)")))) (defun rectangle--extract-region (orig &optional delete) (if (not rectangle-mark-mode) @@ -553,10 +554,10 @@ Activates the region if needed. Only lasts until the region is deactivated." (overlay-put ol 'after-string str)))) ((overlay-get ol 'after-string) (overlay-put ol 'after-string nil))) - (when (= leftcol rightcol) + (when (and (= leftcol rightcol) (display-graphic-p)) ;; Make zero-width rectangles visible! - (overlay-put ol 'after-string - (concat (propertize " " + (overlay-put ol 'after-string + (concat (propertize " " 'face '(region (:height 0.2))) (overlay-get ol 'after-string)))) (push ol nrol) -- 2.39.2