From d4d0a09427ca25cf799024abf18b636a0bfd1474 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Fri, 17 Jun 2022 10:07:47 +0200 Subject: [PATCH] Fix misplaced interactive spec * test/lisp/progmodes/cperl-mode-tests.el (cperl-test-bug-10483): * test/lisp/cedet/srecode/document-tests.el (srecode-document-function-comment-extract-test): * test/lisp/obsolete/inversion-tests.el (inversion-unit-test): * test/lisp/cedet/cedet-files-tests.el (cedet-files-utest): Remove misplaced interactive spec. (cedet-files-utest-list): Minor doc fix; improve formatting. --- test/lisp/cedet/cedet-files-tests.el | 17 +++++++---------- test/lisp/cedet/srecode/document-tests.el | 2 -- test/lisp/obsolete/inversion-tests.el | 1 - test/lisp/progmodes/cperl-mode-tests.el | 1 - 4 files changed, 7 insertions(+), 14 deletions(-) diff --git a/test/lisp/cedet/cedet-files-tests.el b/test/lisp/cedet/cedet-files-tests.el index d264410e3cb..daaf3edfc4e 100644 --- a/test/lisp/cedet/cedet-files-tests.el +++ b/test/lisp/cedet/cedet-files-tests.el @@ -29,20 +29,17 @@ (require 'cedet-files) (defvar cedet-files-utest-list - '( - ( "/home/me/src/myproj/src/foo.c" . "!home!me!src!myproj!src!foo.c" ) - ( "c:/work/myproj/foo.el" . "!drive_c!work!myproj!foo.el" ) - ( "//windows/proj/foo.java" . "!!windows!proj!foo.java" ) - ( "/home/me/proj!bang/foo.c" . "!home!me!proj!!bang!foo.c" ) - ) - "List of different file names to test. -Each entry is a cons cell of ( FNAME . CONVERTED ) + '(("/home/me/src/myproj/src/foo.c" . "!home!me!src!myproj!src!foo.c") + ("c:/work/myproj/foo.el" . "!drive_c!work!myproj!foo.el") + ("//windows/proj/foo.java" . "!!windows!proj!foo.java") + ("/home/me/proj!bang/foo.c" . "!home!me!proj!!bang!foo.c")) + "List of file names to test. +Each entry is a cons cell of (FNAME . CONVERTED) where FNAME is some file name, and CONVERTED is what it should be converted into.") (ert-deftest cedet-files-utest () - "Test out some file name conversions." - (interactive) + "Test some file name conversions." (dolist (FT cedet-files-utest-list) (let ((dir->file (cedet-directory-name-to-file-name (car FT) t)) (file->dir (cedet-file-name-to-directory-name (cdr FT) t))) diff --git a/test/lisp/cedet/srecode/document-tests.el b/test/lisp/cedet/srecode/document-tests.el index 71c4cd7410b..5341bb09366 100644 --- a/test/lisp/cedet/srecode/document-tests.el +++ b/test/lisp/cedet/srecode/document-tests.el @@ -35,8 +35,6 @@ "Test old comment extraction. Dump out the extracted dictionary." :tags '(:unstable) - (interactive) - (srecode-load-tables-for-mode major-mode) (srecode-load-tables-for-mode major-mode 'document) diff --git a/test/lisp/obsolete/inversion-tests.el b/test/lisp/obsolete/inversion-tests.el index 7c8815c2822..8af91d7d147 100644 --- a/test/lisp/obsolete/inversion-tests.el +++ b/test/lisp/obsolete/inversion-tests.el @@ -30,7 +30,6 @@ (ert-deftest inversion-unit-test () "Test inversion to make sure it can identify different version strings." - (interactive) (let ((c1 (inversion-package-version 'inversion)) (c1i (inversion-package-incompatibility-version 'inversion)) (c2 (inversion-decode-version "1.3alpha2")) diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmodes/cperl-mode-tests.el index 4e0debffb69..47e39aa589b 100644 --- a/test/lisp/progmodes/cperl-mode-tests.el +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -747,7 +747,6 @@ without a statement terminator on the same line does not loop forever. The test starts an asynchronous Emacs batch process under timeout control." :tags '(:expensive-test) - (interactive) (skip-unless (not (getenv "EMACS_HYDRA_CI"))) ; FIXME times out (skip-unless (not (< emacs-major-version 28))) ; times out in older Emacsen (skip-unless (eq cperl-test-mode #'cperl-mode)) -- 2.39.2