From cf6a9685f1a33ff97bcbcb5010b56652cdbc8617 Mon Sep 17 00:00:00 2001 From: Glenn Morris Date: Tue, 28 May 2013 19:40:43 -0700 Subject: [PATCH] Silence some gnus compilation warnings * gnus/gnus-ems.el (set-process-plist): Every supported Emacs has this. * gnus/gnus-group.el (gnus-sequence-of-unread-articles) (gnus-summary-add-mark, gnus-mark-article-as-read) (gnus-group-make-articles-read): Declare. * gnus/gnus-sum.el (gnus-parameter-list-identifier) (gnus-article-stop-animations, gnus-stop-downloads) (gnus-article-only-boring-p, article-goto-body) (gnus-flush-original-article-buffer, article-narrow-to-head) (gnus-article-hidden-text-p, gnus-delete-wash-type) (gnus-summary-save-in-pipe, gnus-article-show-summary): Declare. * gnus/gnus.el: No need to eval-and-compile autoloads. * gnus/gravatar.el (help-function-arglist): Autoload. * gnus/nnimap.el (gnus-refer-thread-use-nnir): Declare. * gnus/nnmail.el (nnmail-fancy-expiry-target): Maybe use mail-dont-reply-to. * gnus/spam.el: No need to load spam-report when compiling. No need to eval-and-compile autoloads. (spam-report-resend-to): Declare. (spam-report-resend-register-routine): Require 'spam-report. --- lisp/gnus/ChangeLog | 28 ++++++++++++++++++++++++++++ lisp/gnus/gnus-ems.el | 4 ++-- lisp/gnus/gnus-group.el | 7 +++++++ lisp/gnus/gnus-sum.el | 18 ++++++++++++++++++ lisp/gnus/gnus.el | 3 +-- lisp/gnus/gravatar.el | 2 ++ lisp/gnus/nnimap.el | 1 + lisp/gnus/nnmail.el | 4 +++- lisp/gnus/spam.el | 13 +++++++------ 9 files changed, 69 insertions(+), 11 deletions(-) diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog index d475a259113..3cfca4525f0 100644 --- a/lisp/gnus/ChangeLog +++ b/lisp/gnus/ChangeLog @@ -1,3 +1,31 @@ +2013-05-29 Glenn Morris + + * gnus-ems.el (set-process-plist): Every supported Emacs has this. + + * gnus-group.el (gnus-sequence-of-unread-articles) + (gnus-summary-add-mark, gnus-mark-article-as-read) + (gnus-group-make-articles-read): Declare. + + * gnus-sum.el (gnus-parameter-list-identifier) + (gnus-article-stop-animations, gnus-stop-downloads) + (gnus-article-only-boring-p, article-goto-body) + (gnus-flush-original-article-buffer, article-narrow-to-head) + (gnus-article-hidden-text-p, gnus-delete-wash-type) + (gnus-summary-save-in-pipe, gnus-article-show-summary): Declare. + + * gnus.el: No need to eval-and-compile autoloads. + + * gravatar.el (help-function-arglist): Autoload. + + * nnimap.el (gnus-refer-thread-use-nnir): Declare. + + * nnmail.el (nnmail-fancy-expiry-target): Maybe use mail-dont-reply-to. + + * spam.el: No need to load spam-report when compiling. + No need to eval-and-compile autoloads. + (spam-report-resend-to): Declare. + (spam-report-resend-register-routine): Require 'spam-report. + 2013-05-24 Julien Danjou * sieve.el (sieve-setup-buffer): Fix default port value in sieve buffer diff --git a/lisp/gnus/gnus-ems.el b/lisp/gnus/gnus-ems.el index ac8bb74f1f5..4d9b5798247 100644 --- a/lisp/gnus/gnus-ems.el +++ b/lisp/gnus/gnus-ems.el @@ -221,8 +221,8 @@ 'window-inside-pixel-edges 'window-pixel-edges)) - (if (fboundp 'set-process-plist) - (progn + (if (or (featurep 'emacs) (fboundp 'set-process-plist)) + (progn ; these exist since Emacs 22.1 (defalias 'gnus-set-process-plist 'set-process-plist) (defalias 'gnus-process-plist 'process-plist) (defalias 'gnus-process-get 'process-get) diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index 2c45d3c24a1..30ce184ed66 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -3591,6 +3591,8 @@ Cross references (Xref: header) of articles are ignored." (interactive "P") (gnus-group-catchup-current n 'all)) +(declare-function gnus-sequence-of-unread-articles "gnus-sum" (group)) + (defun gnus-group-catchup (group &optional all) "Mark all articles in GROUP as read. If ALL is non-nil, all articles are marked as read. @@ -4493,6 +4495,8 @@ and the second element is the address." (sort (nconc (gnus-uncompress-range (cdr m)) (copy-sequence articles)) '<) t)))))) +(declare-function gnus-summary-add-mark "gnus-sum" (article type)) + (defun gnus-add-mark (group mark article) "Mark ARTICLE in GROUP with MARK, whether the group is displayed or not." (let ((buffer (gnus-summary-buffer-name group))) @@ -4657,6 +4661,9 @@ you the groups that have both dormant articles and cached articles." (let ((gnus-group-list-option 'limit)) (gnus-group-list-plus args))) +(declare-function gnus-mark-article-as-read "gnu-sum" (article &optional mark)) +(declare-function gnus-group-make-articles-read "gnus-sum" (group articles)) + (defun gnus-group-mark-article-read (group article) "Mark ARTICLE read." (let ((buffer (gnus-summary-buffer-name group)) diff --git a/lisp/gnus/gnus-sum.el b/lisp/gnus/gnus-sum.el index f0b17341e77..c8f593ea403 100644 --- a/lisp/gnus/gnus-sum.el +++ b/lisp/gnus/gnus-sum.el @@ -5492,6 +5492,8 @@ or a straight list of headers." (cdr (assq number gnus-newsgroup-scored)) (memq number gnus-newsgroup-processable)))))) +(declare-function gnus-parameter-list-identifier "gnus-art" (name) t) + (defun gnus-group-get-list-identifiers (group) "Get list identifier regexp for GROUP." (or (gnus-parameter-list-identifier group) @@ -7267,6 +7269,9 @@ If FORCE (the prefix), also save the .newsrc file(s)." (unless quit-config (setq gnus-newsgroup-name nil))))) +(declare-function gnus-article-stop-animations "gnus-art" ()) +(declare-function gnus-stop-downloads "gnus-art" ()) + (defalias 'gnus-summary-quit 'gnus-summary-exit-no-update) (defun gnus-summary-exit-no-update (&optional no-questions) "Quit reading current newsgroup without updating read article info." @@ -7859,6 +7864,8 @@ If UNREAD is non-nil, only unread articles are selected." (and gnus-auto-select-same (gnus-summary-article-subject)))) +(declare-function gnus-article-only-boring-p "gnus-art" ()) + (defun gnus-summary-next-page (&optional lines circular stop) "Show next page of the selected article. If at the end of the current article, select the next article. @@ -8426,6 +8433,8 @@ If REVERSE (the prefix), limit to articles that don't match." (interactive "sMatch headers (regexp): \nP") (gnus-summary-limit-to-bodies match reverse t)) +(declare-function article-goto-body "gnus-art" ()) + (defun gnus-summary-limit-to-bodies (match &optional reverse headersp) "Limit the summary buffer to articles that have bodies that match MATCH. If REVERSE (the prefix), limit to articles that don't match." @@ -9556,6 +9565,8 @@ to save in." (ps-spool-buffer-with-faces) (ps-spool-buffer))))) +(declare-function gnus-flush-original-article-buffer "gnus-art" ()) + (defun gnus-summary-show-complete-article () "Show a complete version of the current article. This is only useful if you're looking at a partial version of the @@ -9679,6 +9690,10 @@ If ARG is a negative number, turn header display off." t))) (gnus-summary-show-article)) +(declare-function article-narrow-to-head "gnus-art" ()) +(declare-function gnus-article-hidden-text-p "gnus-art" (type)) +(declare-function gnus-delete-wash-type "gnus-art" (type)) + (defun gnus-summary-toggle-header (&optional arg) "Show the headers if they are hidden, or hide them if they are shown. If ARG is a positive number, show the entire header. @@ -11962,6 +11977,8 @@ will not be marked as saved." (gnus-set-mode-line 'summary) n)) +(declare-function gnus-summary-save-in-pipe "gnus-art" (&optional command raw)) + (defun gnus-summary-pipe-output (&optional n sym) "Pipe the current article to a subprocess. If N is a positive number, pipe the N next articles. @@ -12914,6 +12931,7 @@ If ALL is a number, fetch this number of articles." (gnus-summary-position-point)) ;;; Bookmark support for Gnus. +(declare-function gnus-article-show-summary "gnus-art" ()) (declare-function bookmark-make-record-default "bookmark" (&optional no-file no-context posn)) (declare-function bookmark-prop-get "bookmark" (bookmark prop)) diff --git a/lisp/gnus/gnus.el b/lisp/gnus/gnus.el index fd6ebf338fa..2c2dbd90c56 100644 --- a/lisp/gnus/gnus.el +++ b/lisp/gnus/gnus.el @@ -4243,8 +4243,7 @@ parameters." (setq valids (cdr valids))) outs)) -(eval-and-compile - (autoload 'message-y-or-n-p "message" nil nil 'macro)) +(autoload 'message-y-or-n-p "message" nil nil 'macro) (defun gnus-read-group (prompt &optional default) "Prompt the user for a group name. diff --git a/lisp/gnus/gravatar.el b/lisp/gnus/gravatar.el index bf6295aa7b8..985ed2c7b0d 100644 --- a/lisp/gnus/gravatar.el +++ b/lisp/gnus/gravatar.el @@ -103,6 +103,8 @@ If no image available, return 'error." (gravatar-create-image data nil t) 'error))) +(autoload 'help-function-arglist "help-fns") + ;;;###autoload (defun gravatar-retrieve (mail-address cb &optional cbargs) "Retrieve MAIL-ADDRESS gravatar and call CB on retrieval. diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el index 9c18bc2cff0..8fdd69b47da 100644 --- a/lisp/gnus/nnimap.el +++ b/lisp/gnus/nnimap.el @@ -1642,6 +1642,7 @@ textual parts.") (setq nnimap-status-string "Read-only server") nil) +(defvar gnus-refer-thread-use-nnir) ; gnus-sum (declare-function gnus-fetch-headers "gnus-sum" (articles &optional limit force-new dependencies)) diff --git a/lisp/gnus/nnmail.el b/lisp/gnus/nnmail.el index a266567987d..28b28369ae4 100644 --- a/lisp/gnus/nnmail.el +++ b/lisp/gnus/nnmail.el @@ -1954,7 +1954,9 @@ If TIME is nil, then return the cutoff time for oldness instead." (and (string-match (cadr regexp-target-pair) to) (let ((rmail-dont-reply-to-names (message-dont-reply-to-names))) - (equal (rmail-dont-reply-to from) ""))))) + (equal (if (fboundp 'rmail-dont-reply-to) + (rmail-dont-reply-to from) + (mail-dont-reply-to from)) ""))))) (setq target (format-time-string (caddr regexp-target-pair) date))) ((and (not (equal header 'to-from)) (string-match (cadr regexp-target-pair) diff --git a/lisp/gnus/spam.el b/lisp/gnus/spam.el index 725017ca116..8d689bf26bd 100644 --- a/lisp/gnus/spam.el +++ b/lisp/gnus/spam.el @@ -50,7 +50,6 @@ ;;; for the definitions of group content classification and spam processors (require 'gnus) -(eval-when-compile (require 'spam-report)) (eval-when-compile (require 'hashcash)) ;; for nnimap-split-download-body-default @@ -60,11 +59,10 @@ (autoload 'query-dig "dig") ;; autoload spam-report -(eval-and-compile - (autoload 'spam-report-gmane "spam-report") - (autoload 'spam-report-gmane-spam "spam-report") - (autoload 'spam-report-gmane-ham "spam-report") - (autoload 'spam-report-resend "spam-report")) +(autoload 'spam-report-gmane "spam-report") +(autoload 'spam-report-gmane-spam "spam-report") +(autoload 'spam-report-gmane-ham "spam-report") +(autoload 'spam-report-resend "spam-report") ;; autoload gnus-registry (autoload 'gnus-registry-group-count "gnus-registry") @@ -2473,7 +2471,10 @@ With a non-nil REMOVE, remove the ADDRESSES." (defun spam-report-resend-register-ham-routine (articles) (spam-report-resend-register-routine articles t)) +(defvar spam-report-resend-to) + (defun spam-report-resend-register-routine (articles &optional ham) + (require 'spam-report) (let* ((resend-to-gp (if ham (gnus-parameter-ham-resend-to gnus-newsgroup-name) -- 2.39.2