From cd39edb5d641f82accad21cd85ff26b3995f1c85 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Thu, 28 Sep 2017 12:24:44 +0100 Subject: [PATCH] Remove old flymake-display-err-menu-for-current-line, it's useless See https://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00949.html * lisp/progmodes/flymake-ui.el (flymake-popup-current-error-menu): Remove. --- lisp/progmodes/flymake.el | 32 -------------------------------- 1 file changed, 32 deletions(-) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 0071ba93eac..20c94d20d8b 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -467,38 +467,6 @@ associated `flymake-category' return DEFAULT." (flymake-log :debug "starting syntax check after no changes for some time") (flymake-start))))) -(define-obsolete-function-alias 'flymake-display-err-menu-for-current-line - 'flymake-popup-current-error-menu "24.4") - -(defun flymake-popup-current-error-menu (&optional event) - "Pop up a menu with errors/warnings for current line." - (interactive (list last-nonmenu-event)) - (let* ((diag-overlays (or - (flymake--overlays :filter 'flymake--diagnostic - :beg (line-beginning-position) - :end (line-end-position)) - (user-error "No flymake problem for current line"))) - (menu (mapcar (lambda (ov) - (let ((diag (overlay-get ov 'flymake--diagnostic))) - (cons (flymake--diag-text diag) - ov))) - diag-overlays)) - (event (if (mouse-event-p event) - event - (list 'mouse-1 (posn-at-point)))) - (diagnostics (mapcar (lambda (ov) (overlay-get ov 'flymake--diagnostic)) - diag-overlays)) - (title (format "Line %d: %d diagnostics(s)" - (line-number-at-pos) - (length diagnostics))) - (choice (x-popup-menu event (list title (cons "" menu))))) - (flymake-log :debug "choice=%s" choice) - ;; FIXME: What is the point of going to the problem locus if we're - ;; certainly already there? - ;; - (when choice (goto-char (overlay-start choice))))) - - ;; Nothing in flymake uses this at all any more, so this is just for ;; third-party compatibility. (define-obsolete-function-alias 'flymake-display-warning 'message-box "26.1") -- 2.39.5