From c6b4eed80ae3529ada01ca6a5ef5d5b196e97bde Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 3 Aug 2019 14:43:44 -0700 Subject: [PATCH] Fix ordering of Gnus groups after yanking * lisp/gnus/gnus-start.el (gnus-group-change-level): Fix docstring to note that the inserted group is inserted *before* the PREVIOUS group. Fix indexing -- shouldn't have been adding one to the index. --- lisp/gnus/gnus-start.el | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lisp/gnus/gnus-start.el b/lisp/gnus/gnus-start.el index d726ee5aaba..0f91c4d9b4e 100644 --- a/lisp/gnus/gnus-start.el +++ b/lisp/gnus/gnus-start.el @@ -1257,7 +1257,7 @@ or a list (if FROMKILLED is t, it's a list on the format (NUM INFO-LIST), otherwise it's a list in the format of the `gnus-newsrc-hashtb' entries. LEVEL is the new level of the group, OLDLEVEL is the old level and PREVIOUS is the group (a -string name) to insert this group after." +string name) to insert this group before." (let (group info active num) ;; Glean what info we can from the arguments. (if (consp entry) @@ -1343,10 +1343,8 @@ string name) to insert this group after." (puthash group (list num info) gnus-newsrc-hashtb) (when (stringp previous) (setq previous (gnus-group-entry previous))) - (let* ((prev-idx (seq-position gnus-group-list (caadr previous))) - (idx (if prev-idx - (1+ prev-idx) - (length gnus-group-list)))) + (let ((idx (or (seq-position gnus-group-list (caadr previous)) + (length gnus-group-list)))) (push group (nthcdr idx gnus-group-list))) (gnus-dribble-enter (format "(gnus-group-set-info '%S)" info) -- 2.39.2