From c16b296939c9048c6031ce4cb66e5903488fd063 Mon Sep 17 00:00:00 2001 From: Po Lu Date: Sat, 26 Mar 2022 12:20:23 +0800 Subject: [PATCH] Fix crash when windows are destroyed by faulty clients * src/xterm.c (x_dnd_compute_toplevels): Make sure property_reply is non-NULL before testing its format and length. --- src/xterm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/xterm.c b/src/xterm.c index e20efd67c79..7edec2cd401 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -1025,8 +1025,9 @@ x_dnd_compute_toplevels (struct x_display_info *dpyinfo) free (error); } - if (xcb_get_property_value_length (property_reply) != 8 - || property_reply->format != 32) + if (property_reply + && (xcb_get_property_value_length (property_reply) != 8 + || property_reply->format != 32)) rc = false; geometry_reply = xcb_get_geometry_reply (dpyinfo->xcb_connection, -- 2.39.2