From b9a938f1f0c67479a1ad8f124c2a715b0adf5b4d Mon Sep 17 00:00:00 2001 From: Pip Cet Date: Mon, 8 Jul 2024 19:50:16 +0000 Subject: [PATCH] Avoid excessively large backtraces in ert-tests (bug#71988) * test/lisp/emacs-lisp/ert-tests.el (ert-test-run-tests-batch-expensive): Temporarily make `cl-print-object' not print out vectors while running the test. (cherry picked from commit 0264ab11181b1d49d8f07186599396d503f24d1f) --- test/lisp/emacs-lisp/ert-tests.el | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test/lisp/emacs-lisp/ert-tests.el b/test/lisp/emacs-lisp/ert-tests.el index 7ecffa79e77..03a62f74313 100644 --- a/test/lisp/emacs-lisp/ert-tests.el +++ b/test/lisp/emacs-lisp/ert-tests.el @@ -595,9 +595,14 @@ This macro is used to test if macroexpansion in `should' works." :body (lambda () (should (equal complex-list 1)))))) (let ((ert-debug-on-error nil) messages) - (cl-letf* (((symbol-function 'message) + (cl-letf* (((symbol-function 'cl-print-object) + (symbol-function 'cl-print-object)) + ((symbol-function 'message) (lambda (format-string &rest args) (push (apply #'format format-string args) messages)))) + ;; don't print the ert--stats-tests vector, which would run out of + ;; memory if previous tests have failed. + (cl-defmethod cl-print-object ((_object vector) _stream)) (save-window-excursion (let ((case-fold-search nil) (ert-batch-backtrace-right-margin nil) @@ -612,7 +617,9 @@ This macro is used to test if macroexpansion in `should' works." do (unless found-frame (setq found-frame (cl-search frame msg :test 'equal)))) - (should found-frame))))) + (should found-frame)))) + ;; ensure our temporary binding was undone. + (should (equal (cl-prin1-to-string [a]) "[a]"))) (ert-deftest ert-test-special-operator-p () (should (ert--special-operator-p 'if)) -- 2.39.5