From b28efb484712a9c773ded037523b28a1ba688632 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Sun, 11 Mar 2018 13:22:13 +0100 Subject: [PATCH] Fix compile-time warnings due to the statistics-reporting code The code worked because the file is using dynamic binding. --- lisp/use-package/use-package-core.el | 36 ++++++++++++++-------------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el index 84cdb83f48d..33b0e677cff 100644 --- a/lisp/use-package/use-package-core.el +++ b/lisp/use-package/use-package-core.el @@ -967,27 +967,27 @@ If RECURSED is non-nil, recurse into sublists." (setq use-package-statistics (make-hash-table))) (defun use-package-statistics-status (package) - "Return loading configuration status of PACKAGE." - (cond ((gethash :config statistics) "Configured") - ((gethash :init statistics) "Initialized") - ((gethash :preface statistics) "Prefaced") - ((gethash :use-package statistics) "Declared"))) + "Return loading configuration status of PACKAGE statistics." + (cond ((gethash :config package) "Configured") + ((gethash :init package) "Initialized") + ((gethash :preface package) "Prefaced") + ((gethash :use-package package) "Declared"))) (defun use-package-statistics-last-event (package) - "Return the date when package's status last changed. + "Return the date when PACKAGE's status last changed. The date is returned as a string." (format-time-string "%Y-%m-%d %a %H:%M" - (or (gethash :config statistics) - (gethash :init statistics) - (gethash :preface statistics) - (gethash :use-package statistics)))) + (or (gethash :config package) + (gethash :init package) + (gethash :preface package) + (gethash :use-package package)))) (defun use-package-statistics-time (package) - "Return the time is took for package to load." - (+ (float-time (gethash :config-secs statistics 0)) - (float-time (gethash :init-secs statistics 0)) - (float-time (gethash :preface-secs statistics 0)) - (float-time (gethash :use-package-secs statistics 0)))) + "Return the time is took for PACKAGE to load." + (+ (float-time (gethash :config-secs package 0)) + (float-time (gethash :init-secs package 0)) + (float-time (gethash :preface-secs package 0)) + (float-time (gethash :use-package-secs package 0)))) (defun use-package-statistics-convert (package) "Return information about PACKAGE. @@ -999,9 +999,9 @@ The information is formatted in a way suitable for package (vector (symbol-name package) - (use-package-statistics-status package) - (use-package-statistics-last-event package) - (format "%.2f" (use-package-statistics-time package)))))) + (use-package-statistics-status statistics) + (use-package-statistics-last-event statistics) + (format "%.2f" (use-package-statistics-time statistics)))))) (defun use-package-report () "Show current statistics gathered about use-package declarations. -- 2.39.2