From b21a3e726feb521d013d3bda6dd8fd8e0c78ad37 Mon Sep 17 00:00:00 2001 From: Mark Oteiza Date: Sun, 18 Dec 2016 07:28:03 -0500 Subject: [PATCH] Use floor of mtime instead of rounding for thumb property This seems to be the correct thing to do, at least more in line with what at least one other implementation does. Anything using gnome-desktop [0] effectively does the same, as gnome_desktop_thumbnail_is_valid applies atol(3) to mtime for comparison and time_t on GNU/Linux is a signed int. [0] https://git.gnome.org/browse/gnome-desktop/ * lisp/image-dired.el (image-dired-create-thumb): Use floor here. --- lisp/image-dired.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/image-dired.el b/lisp/image-dired.el index 96570a503f8..dd0c5b512e7 100644 --- a/lisp/image-dired.el +++ b/lisp/image-dired.el @@ -646,8 +646,7 @@ DIMENSION should be either the symbol 'width or 'height." 'image-dired-cmd-create-thumbnail-program) (let* ((width (int-to-string (image-dired-thumb-size 'width))) (height (int-to-string (image-dired-thumb-size 'height))) - (modif-time (format "%.0f" (float-time (nth 5 (file-attributes - original-file))))) + (modif-time (floor (float-time (nth 5 (file-attributes original-file))))) (thumbnail-nq8-file (replace-regexp-in-string ".png\\'" "-nq8.png" thumbnail-file)) (command -- 2.39.2