From afcbec61147fe84504de0d329ce40031fa79075b Mon Sep 17 00:00:00 2001 From: Glenn Morris Date: Wed, 31 May 2017 21:17:28 -0400 Subject: [PATCH] Quieten compilation of some test files * test/lisp/dired-tests.el (dired-test-bug25609): Mark unused args. * test/src/data-tests.el (binding-test-set-constant-t) (binding-test-set-constant-nil, binding-test-set-constant-keyword) (binding-test-set-constant-nil): Silence compiler. * test/src/regex-tests.el (regex-tests-BOOST): Escape char literal. --- test/lisp/dired-tests.el | 4 ++-- test/src/data-tests.el | 8 ++++---- test/src/regex-tests.el | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el index 1863864abdf..1b814baac58 100644 --- a/test/lisp/dired-tests.el +++ b/test/lisp/dired-tests.el @@ -63,11 +63,11 @@ (dired-recursive-copies 'always)) ; Don't prompt me. (advice-add 'dired-query ; Don't ask confirmation to overwrite a file. :override - (lambda (sym prompt &rest args) (setq dired-query t)) + (lambda (_sym _prompt &rest _args) (setq dired-query t)) '((name . "advice-dired-query"))) (advice-add 'completing-read ; Just return init. :override - (lambda (prompt coll &optional pred match init hist def inherit keymap) + (lambda (_prompt _coll &optional _pred _match init _hist _def _inherit _keymap) init) '((name . "advice-completing-read"))) (dired to) diff --git a/test/src/data-tests.el b/test/src/data-tests.el index 8caafc11c2f..00a30559e32 100644 --- a/test/src/data-tests.el +++ b/test/src/data-tests.el @@ -338,19 +338,19 @@ comparing the subr with a much slower lisp implementation." (ert-deftest binding-test-set-constant-t () "Test setting the constant t" - (should-error (setq t 'bob) :type 'setting-constant)) + (with-no-warnings (should-error (setq t 'bob) :type 'setting-constant))) (ert-deftest binding-test-set-constant-nil () "Test setting the constant nil" - (should-error (setq nil 'bob) :type 'setting-constant)) + (with-no-warnings (should-error (setq nil 'bob) :type 'setting-constant))) (ert-deftest binding-test-set-constant-keyword () "Test setting a keyword constant" - (should-error (setq :keyword 'bob) :type 'setting-constant)) + (with-no-warnings (should-error (setq :keyword 'bob) :type 'setting-constant))) (ert-deftest binding-test-set-constant-nil () "Test setting a keyword to itself" - (should (setq :keyword :keyword))) + (with-no-warnings (should (setq :keyword :keyword)))) ;; More tests to write - ;; kill-local-variable diff --git a/test/src/regex-tests.el b/test/src/regex-tests.el index db187fd4a6a..1364bf6848a 100644 --- a/test/src/regex-tests.el +++ b/test/src/regex-tests.el @@ -424,7 +424,7 @@ differences in behavior.") (let (failures basic icase notbol noteol) (regex-tests-generic-line - ?; "BOOST.tests" regex-tests-BOOST-whitelist + ?\; "BOOST.tests" regex-tests-BOOST-whitelist (if (save-excursion (re-search-forward "^-" nil t)) (setq basic (save-excursion (re-search-forward "REG_BASIC" nil t)) icase (save-excursion (re-search-forward "REG_ICASE" nil t)) -- 2.39.5