From ab2da681b904cd0c7bfac3a6f5fb3347cc591f20 Mon Sep 17 00:00:00 2001 From: Mark Oteiza Date: Mon, 14 Aug 2017 01:54:11 -0400 Subject: [PATCH] Tiny JSON performance improvement Get rid of some needless uses of apply. Measuring with (benchmark-run 10 (json-read-file "test.json")) showed 1.5-2.5% reduction of execution time. * lisp/json.el (json-peek): Nix let-binding. (json-read-string): Use concat for making a string from chars. (json-read-array): Use cond and more appropriate conversion instead of blindly applying. --- lisp/json.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/json.el b/lisp/json.el index 3def94ce042..627e65efa45 100644 --- a/lisp/json.el +++ b/lisp/json.el @@ -193,8 +193,7 @@ Unlike `reverse', this keeps the property-value pairs intact." (defsubst json-peek () "Return the character at point." - (let ((char (char-after (point)))) - (or char :json-eof))) + (or (char-after (point)) :json-eof)) (defsubst json-pop () "Advance past the character at point, returning it." @@ -415,7 +414,7 @@ representation will be parsed correctly." ;; Skip over the '"' (json-advance) (if characters - (apply 'string (nreverse characters)) + (concat (nreverse characters)) ""))) ;; String encoding @@ -639,7 +638,9 @@ become JSON objects." (signal 'json-error (list 'bleah))))) ;; Skip over the "]" (json-advance) - (apply json-array-type (nreverse elements)))) + (pcase json-array-type + (`vector (nreverse (vconcat elements))) + (`list (nreverse elements))))) ;; Array encoding -- 2.39.5