From a7d716d1c5e36dbb3bd12b879c489035c87f4685 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Mon, 29 Aug 2022 19:52:48 +0200 Subject: [PATCH] Add new defgroup image-dired-external * lisp/image/image-dired-external.el (image-dired-external): New defgroup. (image-dired-cmd-create-thumbnail-program) (image-dired-cmd-create-thumbnail-options) (image-dired-cmd-pngnq-program, image-dired-cmd-pngnq-options) (image-dired-cmd-pngcrush-program) (image-dired-cmd-pngcrush-options) (image-dired-cmd-optipng-program) (image-dired-cmd-optipng-options) (image-dired-cmd-create-standard-thumbnail-options) (image-dired-cmd-rotate-original-program) (image-dired-cmd-rotate-original-options) (image-dired-temp-rotate-image-file) (image-dired-rotate-original-ask-before-overwrite) (image-dired-cmd-write-exif-data-program) (image-dired-cmd-write-exif-data-options): Use above new defgroup. --- lisp/image/image-dired-external.el | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/lisp/image/image-dired-external.el b/lisp/image/image-dired-external.el index ef39e2f9382..893d3da843d 100644 --- a/lisp/image/image-dired-external.el +++ b/lisp/image/image-dired-external.el @@ -38,13 +38,18 @@ (defvar image-dired-thumb-width) (defvar image-dired-thumbnail-storage) +(defgroup image-dired-external nil + "External process support for Image-Dired." + :prefix "image-dired-" + :link '(info-link "(emacs) Image-Dired") + :group 'image-dired) + (defcustom image-dired-cmd-create-thumbnail-program (if (executable-find "gm") "gm" "convert") "Executable used to create thumbnail. Used together with `image-dired-cmd-create-thumbnail-options'." :type 'file - :version "29.1" - :group 'image-dired) + :version "29.1") (defcustom image-dired-cmd-create-thumbnail-options (let ((opts '("-size" "%wx%h" "%f[0]" @@ -57,7 +62,6 @@ Available format specifiers are: %w which is replaced by `image-dired-thumb-width', %h which is replaced by `image-dired-thumb-height', %f which is replaced by the file name of the original image and %t which is replaced by the file name of the thumbnail file." - :group 'image-dired :version "29.1" :type '(repeat (string :tag "Argument"))) @@ -72,7 +76,6 @@ which is replaced by the file name of the thumbnail file." "The file name of the `pngquant' or `pngnq' program. It quantizes colors of PNG images down to 256 colors or fewer using the NeuQuant algorithm." - :group 'image-dired :version "29.1" :type '(choice (const :tag "Not Set" nil) file)) @@ -83,7 +86,6 @@ using the NeuQuant algorithm." "Arguments to pass `image-dired-cmd-pngnq-program'. Available format specifiers are the same as in `image-dired-cmd-create-thumbnail-options'." - :group 'image-dired :type '(repeat (string :tag "Argument")) :version "29.1") @@ -91,7 +93,6 @@ Available format specifiers are the same as in "The file name of the `pngcrush' program. It optimizes the compression of PNG images. Also it adds PNG textual chunks with the information required by the Thumbnail Managing Standard." - :group 'image-dired :type '(choice (const :tag "Not Set" nil) file)) (defcustom image-dired-cmd-pngcrush-options @@ -109,13 +110,11 @@ with the information required by the Thumbnail Managing Standard." Available format specifiers are the same as in `image-dired-cmd-create-thumbnail-options', with %q for a temporary file name (typically generated by pnqnq)." - :group 'image-dired :version "26.1" :type '(repeat (string :tag "Argument"))) (defcustom image-dired-cmd-optipng-program (executable-find "optipng") "The file name of the `optipng' program." - :group 'image-dired :version "26.1" :type '(choice (const :tag "Not Set" nil) file)) @@ -123,7 +122,6 @@ temporary file name (typically generated by pnqnq)." "Arguments passed to `image-dired-cmd-optipng-program'. Available format specifiers are described in `image-dired-cmd-create-thumbnail-options'." - :group 'image-dired :version "26.1" :type '(repeat (string :tag "Argument")) :link '(url-link "man:optipng(1)")) @@ -141,7 +139,6 @@ Available format specifiers are described in "Options for creating thumbnails according to the Thumbnail Managing Standard. Available format specifiers are the same as in `image-dired-cmd-create-thumbnail-options', with %m for file modification time." - :group 'image-dired :version "26.1" :type '(repeat (string :tag "Argument"))) @@ -149,7 +146,6 @@ Available format specifiers are the same as in "jpegtran" "Executable used to rotate original image. Used together with `image-dired-cmd-rotate-original-options'." - :group 'image-dired :type 'file) (defcustom image-dired-cmd-rotate-original-options @@ -161,7 +157,6 @@ number of (positive) degrees to rotate the image, normally 90 or 270 \(for 90 degrees right and left), %o which is replaced by the original image file name and %t which is replaced by `image-dired-temp-image-file'." - :group 'image-dired :version "26.1" :type '(repeat (string :tag "Argument"))) @@ -169,13 +164,11 @@ original image file name and %t which is replaced by (expand-file-name ".image-dired_rotate_temp" (locate-user-emacs-file "image-dired/")) "Temporary file for rotate operations." - :group 'image-dired :type 'file) (defcustom image-dired-cmd-write-exif-data-program "exiftool" "Program used to write EXIF data to image. Used together with `image-dired-cmd-write-exif-data-options'." - :group 'image-dired :type 'file) (defcustom image-dired-cmd-write-exif-data-options @@ -185,7 +178,6 @@ Used with `image-dired-cmd-write-exif-data-program'. Available format specifiers are: %f which is replaced by the image file name, %t which is replaced by the tag name and %v which is replaced by the tag value." - :group 'image-dired :version "26.1" :type '(repeat (string :tag "Argument"))) -- 2.39.2