From a2877f1d6f917de6776849f35ed196f3b5615eb4 Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Tue, 1 Dec 2009 19:39:52 +0000 Subject: [PATCH] (pcomplete-std-complete): Don't try to complete past the last element. --- lisp/ChangeLog | 3 +++ lisp/pcomplete.el | 31 +++++++++++++++++-------------- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 00bb0c5606e..d221bf207af 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,5 +1,8 @@ 2009-12-01 Stefan Monnier + * pcomplete.el (pcomplete-std-complete): Don't try to complete past + the last element. + * simple.el (normal-erase-is-backspace-mode): Fix thinko in message. 2009-12-01 Glenn Morris diff --git a/lisp/pcomplete.el b/lisp/pcomplete.el index a620880e0f7..d4258fe35f0 100644 --- a/lisp/pcomplete.el +++ b/lisp/pcomplete.el @@ -480,28 +480,31 @@ Same as `pcomplete' but using the standard completion UI." (pcomplete-begin))) (buftext (buffer-substring beg (point))) (table - (if (not (equal pcomplete-stub buftext)) - ;; This isn't always strictly right (e.g. if - ;; FOO="toto/$FOO", then completion of /$FOO/bar may - ;; result in something incorrect), but given the lack of - ;; any other info, it's about as good as it gets, and in - ;; practice it should work just fine (fingers crossed). - (let ((prefixes (pcomplete--common-quoted-suffix - pcomplete-stub buftext))) - (apply-partially - 'pcomplete--table-subvert - completions - (cdr prefixes) (car prefixes))) + (cond + ((null completions) nil) + ((not (equal pcomplete-stub buftext)) + ;; This isn't always strictly right (e.g. if + ;; FOO="toto/$FOO", then completion of /$FOO/bar may + ;; result in something incorrect), but given the lack of + ;; any other info, it's about as good as it gets, and in + ;; practice it should work just fine (fingers crossed). + (let ((prefixes (pcomplete--common-quoted-suffix + pcomplete-stub buftext))) + (apply-partially + 'pcomplete--table-subvert + completions + (cdr prefixes) (car prefixes)))) + (t (lexical-let ((completions completions)) (lambda (string pred action) (let ((res (complete-with-action action completions string pred))) (if (stringp res) (pcomplete-quote-argument res) - res)))))) + res))))))) (pred ;; pare it down, if applicable - (when (and pcomplete-use-paring pcomplete-seen) + (when (and table pcomplete-use-paring pcomplete-seen) (setq pcomplete-seen (mapcar (lambda (f) (funcall pcomplete-norm-func -- 2.39.5