From 9c81149ae9165b0f017d60d141221b340879baef Mon Sep 17 00:00:00 2001 From: Lars Ingebrigtsen Date: Wed, 9 Oct 2019 21:55:41 +0200 Subject: [PATCH] Make mml-secure-epg-sign bug out if we can't find an identity * lisp/gnus/mml-sec.el (mml-secure-epg-sign): Bug out if we couldn't find anything to sign with instead of silently pretending to sign. * lisp/gnus/mml-smime.el (mml-smime-epg-sign): Don't bind inhibit-display because that makes debugging impossible. --- lisp/gnus/mml-sec.el | 2 ++ lisp/gnus/mml-smime.el | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/mml-sec.el b/lisp/gnus/mml-sec.el index 51578a753da..c7a2d4664e8 100644 --- a/lisp/gnus/mml-sec.el +++ b/lisp/gnus/mml-sec.el @@ -944,6 +944,8 @@ If no one is selected, symmetric encryption will be performed. " (signer-names (mml-secure-signer-names protocol sender)) (signers (mml-secure-signers context signer-names)) signature micalg) + (unless signers + (error "Couldn't find any signer names. Perhaps `mml-secure-smime-sign-with-sender' should be set?")) (when (eq 'OpenPGP protocol) (setf (epg-context-armor context) t) (setf (epg-context-textmode context) t) diff --git a/lisp/gnus/mml-smime.el b/lisp/gnus/mml-smime.el index 659f2b95289..6dcec9f9112 100644 --- a/lisp/gnus/mml-smime.el +++ b/lisp/gnus/mml-smime.el @@ -348,8 +348,7 @@ Whether the passphrase is cached at all is controlled by (autoload 'mml-compute-boundary "mml") (defun mml-smime-epg-sign (cont) - (let ((inhibit-redisplay t) - (boundary (mml-compute-boundary cont))) + (let ((boundary (mml-compute-boundary cont))) (goto-char (point-min)) (let* ((pair (mml-secure-epg-sign 'CMS cont)) (signature (car pair)) -- 2.39.5