From 94d76adde1b4b2bd86168f8d703241f60d1749b2 Mon Sep 17 00:00:00 2001 From: Lars Ingebrigtsen Date: Sun, 19 Jun 2022 15:29:21 +0200 Subject: [PATCH] Don't handle reverseVideo X resource specially * lisp/term/x-win.el (window-system-initialization): Don't handle reverseVideo specially (bug#32921). --- etc/NEWS | 8 ++++++++ lisp/term/x-win.el | 8 -------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 81b34a1643f..8103ac0d67f 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -151,6 +151,14 @@ of 'user-emacs-directory'. * Incompatible changes in Emacs 29.1 +--- +** Previously, the X reverseVideo value at startup was heeded for all frames. +This meant that if you had a reverseVideo resource on the initial +display, and then opened up a new frame on a display without any +explicit reverseVideo setting, it would get heeded there, too. (This +included terminal frames.) In Emacs 29, the reverseVideo X resource +is handled like all the other X resources, and set on a per-frame basis. + +++ ** 'E' in 'query-replace' now edits the replacement with exact case. Previously, this command did the same as 'e'. diff --git a/lisp/term/x-win.el b/lisp/term/x-win.el index 1f29b24ef20..31fc3ba534d 100644 --- a/lisp/term/x-win.el +++ b/lisp/term/x-win.el @@ -1291,14 +1291,6 @@ This returns an error if any Emacs frames are X frames." (cons (cons 'width (cdr (assq 'width parsed))) default-frame-alist)))))) - ;; Check the reverseVideo resource. - (let ((case-fold-search t)) - (let ((rv (x-get-resource "reverseVideo" "ReverseVideo"))) - (if (and rv - (string-match "^\\(true\\|yes\\|on\\)$" rv)) - (setq default-frame-alist - (cons '(reverse . t) default-frame-alist))))) - ;; Set x-selection-timeout, measured in milliseconds. (let ((res-selection-timeout (x-get-resource "selectionTimeout" "SelectionTimeout"))) -- 2.39.2