From 89749a62b51e19a39f145a1985ae5992c58c6776 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Wed, 25 Aug 2021 19:50:27 +0100 Subject: [PATCH] Make NS toolbar item ID more unique (bug#50160) * src/nsmenu.m ([EmacsToolbar addDisplayItemWithImage:idx:tag:labelText:helpText:enabled:]): Add the label to the identifier to avoid collisions between toolbar items that use the same image. --- src/nsmenu.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nsmenu.m b/src/nsmenu.m index f42cd387022..d15386641f8 100644 --- a/src/nsmenu.m +++ b/src/nsmenu.m @@ -1255,8 +1255,8 @@ update_frame_tool_bar (struct frame *f) NSTRACE ("[EmacsToolbar addDisplayItemWithImage: ...]"); /* 1) come up w/identifier */ - NSString *identifier - = [NSString stringWithFormat: @"%lu", (unsigned long)[img hash]]; + NSString *identifier = [NSString stringWithFormat: @"%lu%@", + (unsigned long)[img hash], label]; [activeIdentifiers addObject: identifier]; /* 2) create / reuse item */ -- 2.39.2