From 860ae4521f69729e5e94f567a95bd790872b888b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jan=20Dj=C3=A4rv?= Date: Sun, 2 Nov 2014 19:45:50 +0100 Subject: [PATCH] Fix memory leak * nsimage.m (allocInitFromFile:): Initialize bmRep. (dealloc): Release bmRep. --- src/ChangeLog | 3 +++ src/nsimage.m | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/ChangeLog b/src/ChangeLog index 07bb1e3fc85..2f719681afb 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,5 +1,8 @@ 2014-11-02 Jan Djärv + * nsimage.m (allocInitFromFile:): Initialize bmRep. + (dealloc): Release bmRep. + * nsterm.h (EmacsImage): Remove imageListNext, refCount, reference, imageListSetNext, imageListNext. diff --git a/src/nsimage.m b/src/nsimage.m index 5bbf9fb49cd..580d8f327c2 100644 --- a/src/nsimage.m +++ b/src/nsimage.m @@ -174,6 +174,7 @@ ns_set_alpha (void *img, int x, int y, unsigned char a) image = [[EmacsImage alloc] initByReferencingFile: [NSString stringWithUTF8String: SSDATA (found)]]; + image->bmRep = nil; #ifdef NS_IMPL_COCOA imgRep = [NSBitmapImageRep imageRepWithData:[image TIFFRepresentation]]; #else @@ -199,6 +200,7 @@ ns_set_alpha (void *img, int x, int y, unsigned char a) - (void)dealloc { [stippleMask release]; + [bmRep release]; [super dealloc]; } -- 2.39.5