From 81131ff26fe2a36c2ed0a4853d85af3bcb8bbdb1 Mon Sep 17 00:00:00 2001 From: Philipp Stephani Date: Mon, 10 Jul 2017 00:28:50 +0200 Subject: [PATCH] Re-add a useful assertion * src/emacs-module.c (module_free_global_ref): Re-add assertion that the reference count is zero. This assertion was removed in commit 8afaa1321f8088bfb877fe4b6676e8517adb0bb7, but it's not included in the test performed by XFASTINT before, because the previous reference count could have been zero already in the case of a buggy implementation. This assertion might have detected Bug#27587. --- src/emacs-module.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/emacs-module.c b/src/emacs-module.c index ba996982604..7e0ba3c16c1 100644 --- a/src/emacs-module.c +++ b/src/emacs-module.c @@ -328,7 +328,10 @@ module_free_global_ref (emacs_env *env, emacs_value ref) set_hash_value_slot (h, i, value); } else - hash_remove_from_table (h, obj); + { + eassert (refcount == 0); + hash_remove_from_table (h, obj); + } } if (module_assertions) -- 2.39.2