From 8048caab1d4125991b475be0ff8052f319221174 Mon Sep 17 00:00:00 2001 From: Glenn Morris Date: Mon, 12 Mar 2018 11:29:01 -0700 Subject: [PATCH] Make compiler warn about use of obsolete hooks * lisp/emacs-lisp/bytecomp.el (byte-compile-form): Warn about using obsolete hooks. --- lisp/emacs-lisp/bytecomp.el | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 2a986f6cbbc..b3ea9300b01 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -3119,6 +3119,11 @@ for symbols generated by the byte compiler itself." (when (assq var byte-compile-lexical-variables) (byte-compile-report-error (format-message "%s cannot use lexical var `%s'" fn var)))))) + ;; Warn about using obsolete hooks. + (if (memq fn '(add-hook remove-hook)) + (let ((hook (car-safe (cdr form)))) + (if (eq (car-safe hook) 'quote) + (byte-compile-check-variable (cadr hook) nil)))) (when (and (byte-compile-warning-enabled-p 'suspicious) (macroexp--const-symbol-p fn)) (byte-compile-warn "`%s' called as a function" fn)) -- 2.39.5