From 7e8f7e089f3e72644c9a6e0d022d51d3166bbb07 Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Sat, 8 Aug 2015 19:43:14 -0400 Subject: [PATCH] * test/automated/ert-tests.el (ert-test-deftest): Add FIXME. --- test/automated/ert-tests.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/automated/ert-tests.el b/test/automated/ert-tests.el index fcfc7ee4823..5382c400962 100644 --- a/test/automated/ert-tests.el +++ b/test/automated/ert-tests.el @@ -345,6 +345,10 @@ This macro is used to test if macroexpansion in `should' works." (should (equal actual-condition expected-condition))))))) (ert-deftest ert-test-deftest () + ;; FIXME: These tests don't look very good. What is their intent, i.e. what + ;; are they really testing? The precise generated code shouldn't matter, so + ;; we should either test the behavior of the code, or else try to express the + ;; kind of efficiency guarantees we're looking for. (should (equal (macroexpand '(ert-deftest abc () "foo" :tags '(bar))) '(progn (ert-set-test 'abc -- 2.39.2