From 76fb19b359dec8556dc66dbac3ad3d333feea3c3 Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Sun, 29 May 2016 20:45:43 -0400 Subject: [PATCH] * lisp/wid-edit.el (link): Remove :follow-link property (bug#22434) * lisp/recentf.el (recentf-dialog-mode-map): Remove unecessary mapping. --- lisp/recentf.el | 1 - lisp/wid-edit.el | 8 +++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/lisp/recentf.el b/lisp/recentf.el index df7f3e2e565..3321f2fe101 100644 --- a/lisp/recentf.el +++ b/lisp/recentf.el @@ -1064,7 +1064,6 @@ Go to the beginning of buffer if not found." (define-key km "q" 'recentf-cancel-dialog) (define-key km "n" 'next-line) (define-key km "p" 'previous-line) - (define-key km [follow-link] "\C-m") km) "Keymap used in recentf dialogs.") diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index 0a0f4582b32..9ede9a5633f 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -1789,7 +1789,13 @@ If END is omitted, it defaults to the length of LIST." "An embedded link." :button-prefix 'widget-link-prefix :button-suffix 'widget-link-suffix - :follow-link 'mouse-face + ;; The `follow-link' property should only be used in those contexts where the + ;; mouse-1 event normally doesn't follow the link, yet the `link' widget + ;; seems to almost always be used in contexts where (down-)mouse-1 is bound + ;; to `widget-button-click' and hence the "mouse-1 to mouse-2" remapping is + ;; not necessary (and can even be harmful). So let's not add a :follow-link + ;; by default. See (bug#22434). + ;; :follow-link 'mouse-face :help-echo "Follow the link." :format "%[%t%]") -- 2.39.2