From 71928f6df502c654609d14784e0c7e09dcf81cc4 Mon Sep 17 00:00:00 2001 From: Tassilo Horn Date: Sun, 26 Jan 2025 09:44:59 +0100 Subject: [PATCH] Use dired--inhibit-auto-revert for fixing bug#71264 The original fix bound auto-revert-mode to nil which had the side-effect of disabling auto-revert forever in this buffer because auto-revert-handler removes the buffer from auto-revert-buffer-list when it's called but auto-revert-mode is nil. * lisp/dired.el (dired-internal-do-deletions): Bind dired--inhibit-auto-revert during deletion (bug#71264). (cherry picked from commit 01d93d56cd469ddb45d142da948caef9f2dc1a3f) --- lisp/dired.el | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lisp/dired.el b/lisp/dired.el index 21dec6ac57d..d040540a49b 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -4082,13 +4082,12 @@ non-empty directories is allowed." (while l (goto-char (marker-position (cdr (car l)))) (dired-move-to-filename) - (let ((inhibit-read-only t)) + (let ((inhibit-read-only t) + ;; Temporarily prevent auto-revert while deleting + ;; entry in the dired buffer (bug#71264). + (dired--inhibit-auto-revert t)) (condition-case err - (let ((fn (car (car l))) - ;; Temporarily prevent auto-revert while - ;; deleting entry in the dired buffer - ;; (bug#71264). - (auto-revert-mode nil)) + (let ((fn (car (car l)))) (dired-delete-file fn dired-recursive-deletes trash) ;; if we get here, removing worked (setq succ (1+ succ)) -- 2.39.5