From 6a5043e9f6dc8120f82d13ebde976df5f0a2ea73 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Wed, 14 Sep 2022 13:51:41 +0300 Subject: [PATCH] Fix more misleading cl-case quoting in tests * test/lisp/dnd-tests.el (x-begin-drag): * test/lisp/so-long-tests/so-long-tests-helpers.el (so-long-tests-assert-active, so-long-tests-assert-reverted): Remove misleading quoting in cl-case clauses (bug#51368). --- test/lisp/dnd-tests.el | 10 +++++----- test/lisp/so-long-tests/so-long-tests-helpers.el | 12 ++++++------ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/test/lisp/dnd-tests.el b/test/lisp/dnd-tests.el index 88f6e694577..67b660fc124 100644 --- a/test/lisp/dnd-tests.el +++ b/test/lisp/dnd-tests.el @@ -52,13 +52,13 @@ ;; Verify that the action is valid and pretend the drag succeeded ;; (by returning the action). (cl-ecase action - ('XdndActionCopy action) - ('XdndActionMove action) - ('XdndActionLink action) + (XdndActionCopy action) + (XdndActionMove action) + (XdndActionLink action) ;; These two are not technically valid, but x-begin-drag accepts ;; them anyway. - ('XdndActionPrivate action) - ('XdndActionAsk 'XdndActionPrivate)))) + (XdndActionPrivate action) + (XdndActionAsk 'XdndActionPrivate)))) ;; This doesn't work during tests. (defalias 'gui-set-selection diff --git a/test/lisp/so-long-tests/so-long-tests-helpers.el b/test/lisp/so-long-tests/so-long-tests-helpers.el index 852e7811cc3..79df532f899 100644 --- a/test/lisp/so-long-tests/so-long-tests-helpers.el +++ b/test/lisp/so-long-tests/so-long-tests-helpers.el @@ -41,14 +41,14 @@ (should (eq so-long--active t)) ;; pcase fails here in Emacs 24. (cl-case action - ('so-long-mode + (so-long-mode (should (eq major-mode 'so-long-mode)) (so-long-tests-assert-overrides) (so-long-tests-assert-preserved)) - ('so-long-minor-mode + (so-long-minor-mode (should (eq so-long-minor-mode t)) (so-long-tests-assert-overrides)) - ('longlines-mode + (longlines-mode (should (eq longlines-mode t)))))) (defun so-long-tests-assert-reverted (action) @@ -61,14 +61,14 @@ (should (eq so-long--active nil)) ;; pcase fails here in Emacs 24. (cl-case action - ('so-long-mode + (so-long-mode (should-not (eq major-mode 'so-long-mode)) (so-long-tests-assert-overrides-reverted) (so-long-tests-assert-preserved)) - ('so-long-minor-mode + (so-long-minor-mode (should-not (eq so-long-minor-mode t)) (so-long-tests-assert-overrides-reverted)) - ('longlines-mode + (longlines-mode (should-not (eq longlines-mode t)))))) (defun so-long-tests-assert-and-revert (action) -- 2.39.2