From 6807d8ca512a3516df3e56e185204f2845bc121e Mon Sep 17 00:00:00 2001 From: Chong Yidong Date: Mon, 10 Aug 2009 02:44:58 +0000 Subject: [PATCH] Update comment (from Kevin Ryde). --- lisp/progmodes/compile.el | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index cad19b70674..6249f50cc9c 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -234,11 +234,19 @@ of[ \t]+\"?\\([a-zA-Z]?:?[^\":\n]+\\)\"?:" 3 2 nil (1)) (2 (compilation-face '(3)))) (gnu - ;; I have no idea what this first line is supposed to match, but it - ;; makes things ambiguous with output such as "foo:344:50:blabla" since - ;; the "foo" part can match this first line (in which case the file - ;; name as "344"). To avoid this, the second line disallows filenames - ;; exclusively composed of digits. --Stef + ;; The first line matches the program name for + + ;; PROGRAM:SOURCE-FILE-NAME:LINENO: MESSAGE + + ;; format, which is used for non-interactive programs other than + ;; compilers (e.g. the "jade:" entry in compilation.txt). + + ;; This first line makes things ambiguous with output such as + ;; "foo:344:50:blabla" since the "foo" part can match this first + ;; line (in which case the file name as "344"). To avoid this, + ;; the second line disallows filenames exclusively composed of + ;; digits. + ;; Similarly, we get lots of false positives with messages including ;; times of the form "HH:MM:SS" where MM is taken as a line number, so ;; the last line tries to rule out message where the info after the -- 2.39.5