From 66c350ad04800031ea39ed3036cb2565994fe9da Mon Sep 17 00:00:00 2001 From: Daniel Colascione Date: Tue, 15 Jan 2019 01:55:06 -0500 Subject: [PATCH] Check for single-threadedness --- src/pdumper.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/pdumper.c b/src/pdumper.c index 956d90cc853..cf2aaf474bb 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -451,10 +451,7 @@ struct dump_flags /* Pack objects tighter than GC memory alignment would normally require. Useful for objects copied into the Emacs image instead of used directly from the loaded dump. - - XXX: actually use - - */ + */ bool_bf pack_objects : 1; /* Sometimes we dump objects that we've already scanned for outbound references to other objects. These objects should not cause new @@ -4033,10 +4030,12 @@ types. */) "dumper. Dumping with the portable dumper may produce " "unexpected results."); - // XXX: check that we have no other threads running if (!main_thread_p (current_thread)) error ("Function can be called only on main thread"); + if (!NILP (XCDR (Fall_threads ()))) + error ("No other threads can be running"); + /* Clear out any detritus in memory. */ do { number_finalizers_run = 0; -- 2.39.5