From 630515294c28dc0778866b9eb9ddcf4fd0f5bc82 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Sun, 16 Mar 2025 09:45:25 +0100 Subject: [PATCH] Only disable 'completion-preview-active-mode' when it is on * lisp/completion-preview.el (completion-preview--post-command): Avoid calling 'completion-preview-active-mode' to disable the mode when already off, since it forces a costly redisplay. (Bug#76964) (cherry picked from commit b6b4a080a3abb5a45b680e26f93dd17adbb75f69) --- lisp/completion-preview.el | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el index e4bbb3165c1..9f5024c9a89 100644 --- a/lisp/completion-preview.el +++ b/lisp/completion-preview.el @@ -663,12 +663,17 @@ point, otherwise hide it." ;; If we're called after a command that itself updates the ;; preview, don't do anything. - (unless internal-p - (if (and (completion-preview-require-certain-commands) - (completion-preview-require-minimum-symbol-length) - (not buffer-read-only)) - (completion-preview--show) - (completion-preview-hide))))) + (cond + (internal-p + ;; `this-command' took care of updating the preview. Do nothing. + ) + ((and (completion-preview-require-certain-commands) + (completion-preview-require-minimum-symbol-length)) + ;; All conditions met. Show or update the preview. + (completion-preview--show)) + (completion-preview-active-mode + ;; The preview is shown, but it shouldn't be. Hide it. + (completion-preview-hide))))) (defun completion-preview--barf-if-no-preview () "Signal a `user-error' if completion preview is not active." -- 2.39.5