From 585e2103df144664921670878fc273eee817b0ba Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Thu, 11 Nov 2021 18:39:19 +0100 Subject: [PATCH] erc: Don't announce broken functionality in /query docstring * lisp/erc/erc.el (erc-cmd-QUERY): Be less enthusiastic about announcing missing/broken functionality. The comment "except this is broken right now" has been there since 2008, and it's not obvious to me that we should ever re-add it. --- lisp/erc/erc.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index 30285687536..abb1f64a822 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -3606,11 +3606,13 @@ other people should be displayed." (defun erc-cmd-QUERY (&optional user) "Open a query with USER. -The type of query window/frame/etc will depend on the value of -`erc-query-display'. - -If USER is omitted, close the current query buffer if one exists -- except this is broken now ;-)" +How the query is displayed (in a new window, frame, etc.) depends +on the value of `erc-query-display'." + ;; FIXME: The doc string used to say at the end: + ;; "If USER is omitted, close the current query buffer if one exists + ;; - except this is broken now ;-)" + ;; Does it make sense to have that functionality? What's wrong with + ;; `kill-buffer'? If it makes sense, re-add it. -- SK @ 2021-11-11 (interactive (list (read-string "Start a query with: "))) (let ((session-buffer (erc-server-buffer)) -- 2.39.2