From 54a6079ba4c94ba6d8b56987400feeabe0c77955 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Fri, 27 Oct 2023 04:57:26 -0500 Subject: [PATCH] Fix performance regression in completion-pcm--all-completions * lisp/minibuffer.el (completion-pcm--all-completions): Don't copy-sequence. --- lisp/minibuffer.el | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index b38eb49aba8..c32bcee51ed 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -3738,10 +3738,9 @@ PATTERN is as returned by `completion-pcm--string->pattern'." (t ;; The pattern has something interesting to match, in ;; which case we take the opportunity to add an early - ;; completion-score cookie to each completion. + ;; `completion-score' cookie to each completion. (cl-loop with re = (completion-pcm--pattern->regex pattern 'group) - for orig in completions - for comp = (copy-sequence orig) + for comp in completions for score = (completion--flex-score comp re t) when score do (put-text-property 0 1 'completion-score -- 2.39.2