From 4da3ff1f0cc4eec6fa3780a73edb428f5b1e898a Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jo=C3=A3o=20T=C3=A1vora?= Date: Thu, 21 Sep 2023 00:05:07 +0100 Subject: [PATCH] Flymake: do use condition-case-unless-debug The reasons previously highlighted in the FIXME either don't apply anymore or don't outweigh the advantages of using this macro. * lisp/progmodes/flymake.el (flymake--run-backend): Do use condition-case-unless-debug. --- lisp/progmodes/flymake.el | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 30dc749349b..7cb1f222c22 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1120,15 +1120,7 @@ with a report function." (setf (flymake--state-running state) run-token (flymake--state-disabled state) nil (flymake--state-reported-p state) nil)) - ;; FIXME: Should use `condition-case-unless-debug' here, but don't - ;; for two reasons: (1) that won't let me catch errors from inside - ;; `ert-deftest' where `debug-on-error' appears to be always - ;; t. (2) In cases where the user is debugging elisp somewhere - ;; else, and using flymake, the presence of a frequently - ;; misbehaving backend in the global hook (most likely the legacy - ;; backend) will trigger an annoying backtrace. - ;; - (condition-case err + (condition-case-unless-debug err (apply backend (flymake-make-report-fn backend run-token) args) (error -- 2.39.5