From 47b986d4882c0f105fc2129fd06b3f7b48e7ea55 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mattias=20Engdeg=C3=A5rd?= Date: Fri, 23 Sep 2022 15:26:13 +0200 Subject: [PATCH] Remove max-specpdl-size overrun test * test/src/eval-tests.el (eval-tests--exceed-specbind-limit) (eval-exceed-specbind-with-signal-hook): Remove test that is no longer useful, since there is no longer any specpdl limit to overrun. (The test still passed but vacuously so, by hitting the max-lisp-eval-depth limit instead.) This silences an obsoletion warning. --- test/src/eval-tests.el | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/test/src/eval-tests.el b/test/src/eval-tests.el index 1b2ad99360b..bb2f04e8ee1 100644 --- a/test/src/eval-tests.el +++ b/test/src/eval-tests.el @@ -108,26 +108,6 @@ Bug#24912." (should-error (eval (cons 'cond clauses) nil)) (should-error (eval (cons 'cond clauses) t)))) -(defun eval-tests--exceed-specbind-limit () - (defvar eval-tests--var1) - (defvar eval-tests--var2) - ;; Bind two variables, to make extra sure we hit the - ;; `max-specpdl-size' limit before the `max-lisp-eval-depth' limit. - (let ((eval-tests--var1 1) - (eval-tests--var2 2)) - ;; Recurse until we hit the limit. - (eval-tests--exceed-specbind-limit))) - -(ert-deftest eval-exceed-specbind-with-signal-hook () - "Test for Bug#30481. -Check that Emacs doesn't crash when exceeding specbind limit with -`signal-hook-function' bound. NOTE: Without the fix for -Bug#30481, this test can appear to pass, but cause a -crash/abort/malloc assert failure on the next test." - (let ((max-specpdl-size (/ max-lisp-eval-depth 2)) - (signal-hook-function #'ignore)) - (should-error (eval-tests--exceed-specbind-limit)))) - (ert-deftest defvar/bug31072 () "Check that Bug#31072 is fixed." (should-error (eval '(defvar 1) t) :type 'wrong-type-argument)) -- 2.39.2