From 439a3cd29dce275c98012972d3a1d1f4b5b50786 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Tue, 13 Sep 2022 18:54:14 +0200 Subject: [PATCH] ; Prefer string-join in image-dired * lisp/image/image-dired-dired.el (subr-x): Require. (image-dired-dired-display-properties): Prefer string-join. * lisp/image/image-dired.el (subr-x): Require. (image-dired-update-header-line): Prefer string-join. --- lisp/image/image-dired-dired.el | 4 +++- lisp/image/image-dired.el | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lisp/image/image-dired-dired.el b/lisp/image/image-dired-dired.el index ef0323d1665..ab994742ecd 100644 --- a/lisp/image/image-dired-dired.el +++ b/lisp/image/image-dired-dired.el @@ -24,6 +24,8 @@ ;;; Code: +(eval-when-compile (require 'subr-x)) ; for string-join + (require 'image-dired) (defgroup image-dired-dired nil @@ -370,7 +372,7 @@ matching tag will be marked in the Dired buffer." (let* ((file (dired-get-filename)) (file-name (file-name-nondirectory file)) (dired-buf (buffer-name (current-buffer))) - (props (mapconcat #'identity (image-dired-list-tags file) ", ")) + (props (string-join (image-dired-list-tags file) ", ")) (comment (image-dired-get-comment file)) (message-log-max nil)) (if file-name diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index f1074247e92..ff10be2ab4b 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -138,6 +138,7 @@ (eval-when-compile (require 'cl-lib) + (require 'subr-x) ; for string-join (require 'wid-edit)) (require 'image-dired-external) @@ -704,7 +705,7 @@ comment." image-dired-display-image-mode))) (let ((file-name (file-name-nondirectory (image-dired-original-file-name))) (dired-buf (buffer-name (image-dired-associated-dired-buffer))) - (props (mapconcat #'identity (get-text-property (point) 'tags) ", ")) + (props (string-join (get-text-property (point) 'tags) ", ")) (comment (get-text-property (point) 'comment)) (message-log-max nil)) (if file-name -- 2.39.2