From 3f7e746b514759b66c28d30ead24be08f0e01717 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 16 Oct 2022 12:57:51 +0200 Subject: [PATCH] Delete 'package-contact-maintainer' * doc/emacs/package.texi: Remove mention. * etc/NEWS: Remove mention. * lisp/emacs-lisp/package.el: Remove the command. --- doc/emacs/package.texi | 8 +++----- etc/NEWS | 5 ----- lisp/emacs-lisp/package.el | 14 -------------- 3 files changed, 3 insertions(+), 24 deletions(-) diff --git a/doc/emacs/package.texi b/doc/emacs/package.texi index 087e506d6c4..584f85567f2 100644 --- a/doc/emacs/package.texi +++ b/doc/emacs/package.texi @@ -553,16 +553,14 @@ be regarded just like any other package, that can be updated (using @code{package-update}), deleted (using @code{package-delete}) and viewed in the package listing. -@findex package-contact-maintainer @findex package-report-bug @findex package-vc-prepare-patch With the source checkout, you might want to reproduce a bug against the current development head or implement a new feature to scratch an itch. If the package metadata indicates that a maintainer can be -contacted via Email, you can use the commands -@code{package-contact-maintainer} to send them a message, or -@code{package-report-bug} to report a bug that will include all the -user options that you have customised. Patches can be sent out using +contacted via Email, you can use the command @code{package-report-bug} +to report a bug that will include all the user options that you have +customised. Patches can be sent out using @code{package-vc-prepare-patch}, that makes use of @code{vc-prepare-patch} under the hold (@pxref{Preparing Patches}). diff --git a/etc/NEWS b/etc/NEWS index 965d2689b20..0b33718135c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1577,11 +1577,6 @@ symbolic link from the usual package directory to the checkout. This command allows you to send patches to package maintainers, for packages checked out using 'package-vc-install'. -+++ -*** New command 'package-contact-maintainer' -This command gives you a generic way to send messages to package -maintainers. - +++ *** New command 'package-report-bug' This command helps you compose an email for sending bug reports to diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 92f15337671..6c92ff0ba74 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2997,7 +2997,6 @@ either a full name or nil, and EMAIL is a valid email address." "r" #'revert-buffer "~" #'package-menu-mark-obsolete-for-deletion "w" #'package-browse-url - "m" #'package-contact-maintainer "b" #'package-report-bug "x" #'package-menu-execute "h" #'package-menu-quick-help @@ -4551,19 +4550,6 @@ will be signalled in that case." (package--print-email-button maint) (string-trim (substring-no-properties (buffer-string)))))))) -;; TODO: Allow attaching a patch to send directly to the maintainer. -;; Ideally this should be able to detect the local changes, convert -;; these into patches. -(defun package-contact-maintainer (desc) - "Prepare a message to send to the maintainers of a package. -DESC must be a `package-desc' object." - (interactive (list (package--query-desc package-archive-contents)) - package-menu-mode) - (let ((maint (package-maintainers desc)) - (name (package-desc-name desc)) - (subject (read-string "Subject: "))) - (compose-mail maint (format "[%s] %s" name subject)))) - (defun package-report-bug (desc) "Prepare a message to send to the maintainers of a package. DESC must be a `package-desc' object." -- 2.39.5