From 3b038d46e24532bc4bca56f37d30afd70fae388d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mattias=20Engdeg=C3=A5rd?= Date: Thu, 4 May 2023 17:31:15 +0200 Subject: [PATCH] Remove useless handling of erroneous code in Lisp optimiser * lisp/emacs-lisp/byte-opt.el (byte-optimize-form-code-walker): ((closure ...) ...) is a malformed function call; treat it as such. Better malformed function warning location. --- lisp/emacs-lisp/byte-opt.el | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el index d859706c180..d046c4d401c 100644 --- a/lisp/emacs-lisp/byte-opt.el +++ b/lisp/emacs-lisp/byte-opt.el @@ -469,10 +469,6 @@ for speeding up processing.") form (byte-optimize-form newform for-effect)))) - ;; FIXME: Strictly speaking, I think this is a bug: (closure...) - ;; is a *value* and shouldn't appear in the car. - (`((closure . ,_) . ,_) form) - (`(setq ,var ,expr) (let ((lexvar (assq var byte-optimize--lexvars)) (value (byte-optimize-form expr nil))) @@ -500,7 +496,7 @@ for speeding up processing.") (cons fn (mapcar #'byte-optimize-form exps))) (`(,(pred (not symbolp)) . ,_) - (byte-compile-warn-x fn "`%s' is a malformed function" fn) + (byte-compile-warn-x form "`%s' is a malformed function" fn) form) ((guard (when for-effect -- 2.39.5