From 33bcd4f2d28a7101dbc0ea5563e99cd7f117e21b Mon Sep 17 00:00:00 2001 From: =?utf8?q?Mattias=20Engdeg=C3=A5rd?= Date: Mon, 14 Aug 2023 16:48:05 +0200 Subject: [PATCH] Ignore ert-deftest body value * lisp/emacs-lisp/ert.el (ert-deftest): Since the return value of the body isn't going to be used, ignore it explicitly so that the compiler can warn if we try to return something anyway. In particular, this exposes some comparisons whose result weren't actually checked. --- lisp/emacs-lisp/ert.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/ert.el b/lisp/emacs-lisp/ert.el index be9f013ebcf..4ea894f4ede 100644 --- a/lisp/emacs-lisp/ert.el +++ b/lisp/emacs-lisp/ert.el @@ -237,7 +237,9 @@ in batch mode, an error is signaled. `(:expected-result-type ,expected-result)) ,@(when tags-supplied-p `(:tags ,tags)) - :body (lambda () ,@body) + ;; Add `nil' after the body to enable compiler warnings + ;; about unused computations at the end. + :body (lambda () ,@body nil) :file-name ,(or (macroexp-file-name) buffer-file-name))) ',name)))) -- 2.39.2