From 335e9627ca78f7be9eea27f38a530fd51a1e6995 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jan=20Dj=C3=A4rv?= Date: Wed, 1 Oct 2014 20:10:21 +0200 Subject: [PATCH] * xfaces.c (Finternal_set_lisp_face_attribute): Added FIXME comment. --- src/ChangeLog | 1 + src/xfaces.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/src/ChangeLog b/src/ChangeLog index 63fcf130542..31320ed533f 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -2,6 +2,7 @@ * xfaces.c (Finternal_set_lisp_face_attribute): Don't try to make a font_object from a tty frame (Bug#18573). + (Finternal_set_lisp_face_attribute): Added FIXME comment. 2014-09-30 Eli Zaretskii diff --git a/src/xfaces.c b/src/xfaces.c index 5d158f08099..9579bcce572 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -3119,6 +3119,13 @@ FRAME 0 means change the face on all frames, and change the default f = XFRAME (selected_frame); else f = XFRAME (frame); + + /* FIXME: + If frame is t, and selected frame is a tty frame, the font + can't be realized. An improvement wuld be to loop over frames + for a non-tty frame and use that. See discussion in + bug#18573. + */ if (f->terminal->type != output_termcap) { if (! FONT_OBJECT_P (value)) -- 2.39.2