From 2e1caf3254ba6bf6bd764b60b24e298995ec2cb9 Mon Sep 17 00:00:00 2001 From: Lars Ingebrigtsen Date: Sun, 15 Apr 2018 21:03:34 +0200 Subject: [PATCH] Don't warn the user about large files if they are unreadable * lisp/files.el (abort-if-file-too-large): There's no point in warning the user about a too-large file if we're not able to read it (bug#29549). Hopefully this doesn't introduce a race condition between this test and the `file-readable-p' test later. --- lisp/files.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/files.el b/lisp/files.el index 67a9abfa764..d98d09bb1e3 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -2019,6 +2019,8 @@ think it does, because \"free\" is pretty hard to define in practice." OP-TYPE specifies the file operation being performed (for message to user)." (when (and large-file-warning-threshold size (> size large-file-warning-threshold) + ;; No point in warning if we can't read it. + (file-readable-p filename) (not (y-or-n-p (format "File %s is large (%s), really %s? " (file-name-nondirectory filename) (file-size-human-readable size) op-type)))) -- 2.39.5