From 1ebe1605775c0f273957c1541d5b526bb70f7cfb Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Fri, 24 Jan 2020 10:37:59 +0100
Subject: [PATCH] Warn about XFT and about Cairo without HarfBuzz

* configure.ac: Warn about libXFT usage.  Warn about using Cairo
without HarfBuzz.

* etc/NEWS: Announce XFT and HarfBuzz warnings.
---
 configure.ac | 14 ++++++++++++++
 etc/NEWS     | 13 +++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/configure.ac b/configure.ac
index d7b4d0352cc..932142d813a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5891,6 +5891,20 @@ you can continue to support by using '$0 --with-pop'.])
   esac
 fi
 
+if test "${HAVE_XFT}" = yes; then
+AC_MSG_WARN([This configuration uses libXft,
+    which has a number of font rendering issues, and is being considered for
+    removal in the next release of Emacs.  Please consider using Cairo + HarfBuzz
+    instead (they are auto-detected if the relevant development headers are
+    installed).])
+fi
+
+if test "${HAVE_CAIRO}" = "yes" && test "${HAVE_HARFBUZZ}" = no; then
+   AC_MSG_WARN([This configuration uses Cairo, but not HarfBuzz.  We
+    recommend the use of HarfBuzz when using Cairo, please install
+    HarfBuzz development packages.])
+fi
+
 # Let plain 'make' work.
 test "$MAKE" = make || test -f makefile || cat >makefile <<EOF
 .POSIX:
diff --git a/etc/NEWS b/etc/NEWS
index 764eda56a1a..e821a3e95cf 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -41,6 +41,19 @@ available when HarfBuzz is supported, but will not be used by default.
 We strongly recommend building with HarBuzz support. 'x' is still a
 valid backend.
 
+---
+** 'configure' now warns about building with libXft support.
+libXft is unmaintained, and causes a number of problems with modern
+fonts including but not limited to crashes; support for it may be
+removed in a future version of Emacs.  Please consider using
+Cairo + HarfBuzz instead.
+
+---
+** 'configure' now warns about not using HarfBuzz if using Cairo.
+We want to encourage people to use the most modern font features
+available, and this is Cairo + HarfBuzz, so 'configure' now recommends
+that combination.
+
 ---
 ** The ftx font backend driver has been removed.
 It was declared obsolete in Emacs 27.1.
-- 
2.39.2